osdir.com


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Python-Dev] Tests for internal functionality


On Sun, 17 Mar 2019 at 07:27, Terry Reedy <tjreedy at udel.edu> wrote:
>
> On 3/16/2019 3:10 AM, Ivan Pozdeev via Python-Dev wrote:
> > In https://github.com/python/cpython/pull/6541 , I was requested to add
> > tests for an internal C function.
> >
> > As I wrote in
> > https://github.com/python/cpython/pull/6541#issuecomment-445514807 ,
> > it's not clear from the codebase
> >
> > 1) where tests for internal (as opposed to public) functionality should
> > be located
>
> In the same file where they would be if public, which is what you seemed
> to find.  Label somehow, such as 'class InternalsTest(TestCase):' or
> 'test__private' (with double __ indicating test of _private).

A belated follow-up here: in most cases, such tests should be marked
with https://docs.python.org/3/library/test.html#test.support.cpython_only,
so they get skipped automatically when the test suite is run against
another implementation.

Cheers,
Nick.

-- 
Nick Coghlan   |   ncoghlan at gmail.com   |   Brisbane, Australia