[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Python-Dev] make patchcheck and git path


On 28/08/2018 09:57, Stephen J. Turnbull wrote:
> Michael Felt (aixtools) writes:
>
>  > When building out of tree there is no .git reference. If I
>  > understand the process it uses git to see what files have changed,
>  > and does further processing on those.
>
> Just guessing based on generic git knowledge here:
>
> If you build in a sibling directory of the .git directory, git should
> "see" the GITDIR, and it should work.  Where is your build directory
> relative to the GITDIR?
I work in "parallel"
/data/prj/python/python-version
/data/prj/python/git/python-version

I suppose I should try setting GITDIR - but, I think it would be better,
at least nicer, if "patchcheck" as a target did some checking for git
early on, rather than bail out at the end. The results of the check
might be just a message to set GITDIR, e.g..
> I suspect you could also set GITDIR=/path/to/python/source/.git in
> make's process environment, and do "make patchcheck" outside of the
> Python source tree successfully.
I'll give this a try next time around. (vacation, so not really 'active'
atm).

Thanks for the suggestions.
>
> Regards,
>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://mail.python.org/pipermail/python-dev/attachments/20180901/45811506/attachment.sig>