osdir.com


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Python-Dev] Tests failing on Windows with TESTFN


On Sun, Jul 29, 2018 at 2:21 PM, Jeremy Kloth <jeremy.kloth at gmail.com> wrote:
>
>          try:
>              os.rename(new_file.name, self._path)
>          except FileExistsError:
> -            os.remove(self._path)
> +            temp_name = _create_temporary_name(self._path)
> +            os.rename(self._path, temp_name)
>              os.rename(new_file.name, self._path)
> +            os.remove(temp_name)

This should call os.replace to allow the file system to replace the
existing file.