osdir.com

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Python-Dev] GH-NNNN vs #NNNN in merge commit


On 1/26/2018 12:22 PM, Mariatta Wijaya wrote:
>     I believe https://github.com/python/bedevere/pull/82
>     <https://github.com/python/bedevere/pull/82>?will add a comment,
>     which will get emailed to everyone nosy on the PR.
> 
> Yes, and I've just updated my PR description:
> 
> If a PR was merged and the commit message was not changed from 
> |#NNNN|?to |GH-NNNN|, bedevere-bot will leave a comment to remind the 
> core dev to update it next time.
> For example:
> ```
> @Mariatta: Please replace # with GH- in the commit message next time. 
> Thanks!
> ```
> 
> Does that work for everyone?

It works for me: I think this is very helpful. Thanks for coding it up 
so quickly!

Eric