[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Python-Dev] GH-NNNN vs #NNNN in merge commit

On Thu, Jan 25, 2018 at 1:42 PM, INADA Naoki <songofacandy at gmail.com> wrote:
> Hi.
> Devguide says:
> """
> Replace the reference to GitHub pull request #NNNN with GH-NNNN. If
> the title is too long, the pull request number can be added to the
> message body.
> """
> https://devguide.python.org/gitbootcamp/#accepting-and-merging-a-pull-request
> But there are more #NNNN than GH-NNNN in commit log.
> https://github.com/python/cpython/commits/master
> Where should we go?
> Encourage GH-NNNN? or abandon it and use default #NNNN?

I'd personally drop both GH-NNNN and #NNNN markers. The number of the
PR is already linked to the commit on GitHub:

You can even see both styles in the same commit (especially in backport PRs)

     bpo-42: Fix spam eggs (GH-2341) (#2211)