osdir.com

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Python-Dev] [Python-checkins] cpython: Disabling a test that fails on some bots. Will investigate the failure soon


On Fri, Feb 17, 2012 at 2:09 AM, eli.bendersky
<python-checkins at python.org> wrote:
> diff --git a/Lib/test/test_xml_etree_c.py b/Lib/test/test_xml_etree_c.py
> --- a/Lib/test/test_xml_etree_c.py
> +++ b/Lib/test/test_xml_etree_c.py
> @@ -53,8 +53,8 @@
> ? ? ? ? # actual class. In the Python version it's a class.
> ? ? ? ? self.assertNotIsInstance(cET.Element, type)
>
> - ? ?def test_correct_import_cET_alias(self):
> - ? ? ? ?self.assertNotIsInstance(cET_alias.Element, type)
> + ? ?#def test_correct_import_cET_alias(self):
> + ? ? ? ?#self.assertNotIsInstance(cET_alias.Element, type)

While this one was fixed quickly, *please* don't comment tests out
without some kind of explanation in the code (not just in the checkin
message).

Even better is to use the expected_failure() decorator or the skip() decorator.

Cheers,
Nick.

-- 
Nick Coghlan?? |?? ncoghlan at gmail.com?? |?? Brisbane, Australia