osdir.com


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[neutron] Cleaning in Neutron


Wow that's amazing, it's a very large amount of work so please keep me
in the loop to help!

- mike

On Tue, Apr 16, 2019 at 6:00 PM Miguel Lavalle <miguel at mlavalle.com> wrote:
>
> Hi Mike,
>
> Thank you for catching this. This topic was discussed during the September PTG and it was agreed that: "The OVO sub-team has accepted to also continue the adoption of the new engine facade (https://blueprints.launchpad.net/neutron/+spec/enginefacade-switch), since both efforts work in the DB layer and entail traversing the code looking for opportunities of adoption" [1]. Unfortunately, we lost members of the OVO sub-team, to the point that the weekly meeting was recently removed [2]. As a consequence, this will be my personal goal for the Train cycle. I have restored the two patches that you pointed out and I'll re-start the effort from there [3][4]. I am also adding this topic to the discussion during the upcoming PTG.
>
>
> [1] See section "Neutron upgrades/OVO" in http://lists.openstack.org/pipermail/openstack-dev/2018-September/135032.html
> [2] https://review.openstack.org/#/c/645181/
> [3] https://review.openstack.org/#/c/545501/
> [4] https://review.openstack.org/#/c/396121/
>
> On Tue, Apr 16, 2019 at 8:13 AM Mike Bayer <mike_mp at zzzcomputing.com> wrote:
>>
>> There are a lot of very important and large DB related changes here
>> that were unfortunately abandoned by their contributors [1] [2].
>> Neutron remains from a SQLAlchemy / oslo.db perspective in this very
>> awkward state where it is halfway between using legacy oslo.db access
>> patterns and the "newer" enginefacade, which is now four years old.
>> This leads to complicated issues that are difficult to develop around
>> and debug [3].
>>
>> I don't have a solution to this problem as I am not tasked with
>> Neutron to the degree that would be necessary to complete these
>> migrations on my own, however as always, I eagerly await the arrival
>> of developers who can commit to seeing these refactorings through,
>> where I will of course be available to help.
>>
>> [1] https://review.openstack.org/#/c/545501/
>> [2] https://review.openstack.org/#/c/396121/
>> [3] https://review.openstack.org/#/c/348080/57/neutron/tests/unit/extensions/test_subnet_onboard.py at 42
>>
>>
>> On Tue, Apr 16, 2019 at 5:08 AM Slawomir Kaplonski <skaplons at redhat.com> wrote:
>> >
>> > Hi,
>> >
>> > I just run abandon_old_reviews.sh [1] script again for neutron, neutron-lib and neutron-tempest-plugin repositories.
>> > So if You have Your patch abandoned but You want to continue to work on it, please simple restore it or if You canâ??t restore it by self, please ping me on irc (slaweq) and I will restore it for You.
>> >
>> > [1] https://github.com/openstack/neutron/blob/master/tools/abandon_old_reviews.sh
>> >
>> > â??
>> > Slawek Kaplonski
>> > Senior software engineer
>> > Red Hat
>> >
>> >
>>