[telemetry] Procedure for merging patches
Ok, that makes sense to me.
On Thu, Apr 11, 2019 at 4:50 PM Rong Zhu <aaronzhu1121 at gmail.com> wrote:
> As usual, There are have +2s, then the next core can +2/A, why we need PTL
> final +A?
> Rong Zhu
> Trinh Nguyen <dangtrinhnt at gmail.com>äº?2019å¹´4æ??11æ?¥ å?¨å??15:39å??é??ï¼?
>> Hi team,
>> One of the thing that has been brought up in the last meeting is what is
>> the process of merging a patch. So, let's try this first:
>> - For small patches (e.g., change strings, fix typos, update docs):
>> any core can approve for merging.
>> - For a patch that implements a new feature, removes a feature, patch
>> that has huge changes (in the number of changed files and loc, etc.) or any
>> patch that is in doubt: we need at least 2 cores to give a +2 and then the
>> PTL will merge it.
>> Of course, we can change the procedure when we see issues. For now, this
>> should be a guideline for the team.
>> Please feel free to comment.
>> *Trinh Nguyen*
>> *www.edlab.xyz <https://www.edlab.xyz>*
> Rong Zhu
-------------- next part --------------
An HTML attachment was scrubbed...