[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[openstack-dev] [requirements][nova] weird error on 'Validating lower constraints of test-requirements.txt'

Thanks all for helping , Saw this patch [1] merged and assume that's the
fix for the issue , we will rebase based on it then try again,

[1] https://review.openstack.org/#/c/575872/4

Best Regards!

Kevin (Chen) Ji 纪 �

Engineer, zVM Development, CSTL
Notes: Chen CH Ji/China/IBM at IBMCN   Internet: jichenjc at cn.ibm.com
Phone: +86-10-82451493
Address: 3/F Ring Building, ZhongGuanCun Software Park, Haidian District,
Beijing 100193, PRC

From:	Doug Hellmann <doug at doughellmann.com>
To:	openstack-dev <openstack-dev at lists.openstack.org>
Date:	06/16/2018 08:14 AM
Subject:	Re: [openstack-dev] [requirements][nova] weird error on
            'Validating	lower constraints of test-requirements.txt'

Excerpts from Eric Fried's message of 2018-06-15 18:09:49 -0500:
> Doug-
> > The lower constraints tests only look at files in the same repo.
> > The minimum versions of dependencies set in requirements.txt,
> > test-requirements.txt, etc. need to match the values in
> > lower-constraints.txt.
> >
> > In this case, the more detailed error message is a few lines above the
> > error quoted by Chen CH Ji. The detail say "Requirement for package
> > retrying has no lower bound" which means that there is a line in
> > requirements.txt indicating a dependency on "retrying" but without
> > specifying a minimum version. That is the problem.
> The patch didn't change the retrying constraint in requirements.txt [1];
> why isn't this same failure affecting every other patch in nova?
> [1]
https://review.openstack.org/#/c/523387/51/requirements.txt at 65

> -efried

Earlier this cycle I updated the requirements check job to verify
that all of the settings are correct any time any changes to the
dependency lists are made. We used to only look at the line being
changed, but that allowed incorrect settings to stay in place for
a long time so we weren't actually testing with good settings. We
still only run that job when the dependency list is modified in
some way.

Earlier this week, Matt Thode updated the job to be more strict and
to require that all dependencies have a minimum version specified
[2]. We did this because some project teams thought that after we
dropped the minimums from the global-requirements.txt list they
were supposed to (or allowed to) drop them from their project
dependency lists, too.

My guess is that this dependency in nova never had a lower bound and
that this is the first patch to touch the dependency list, so now it's
being blocked on the fact that the list has a validation error.

I recommend using a separate patch to fix the minimum version of
retrying and then rebasing 523387 on top of the new patch.



OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20180618/deaaf2c4/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: graycol.gif
Type: image/gif
Size: 105 bytes
Desc: not available
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20180618/deaaf2c4/attachment.gif>