Re: RegExp problem in VSSHistoryParser::ParseUsernameAndDate()

ok, i've committed thibaut's changes.

> I suspect we may meet this situation again
with other non-english vss (no french exception here ?;)
guess i'm showing my ignorance ;)

cheers,
owen.
---
R. Owen Rogers
ThoughtWorks Technologies (India) Pvt Ltd.

ThoughtWorks - Deliver with passion!

ThoughtWorks is always looking for talented people who are passionate about
technology.  To find out more about a career at ThoughtWorks go to
http://www.thoughtworks.com/career/.

Thibaut Barrère <thibaut.barrere-Re5JQEeQqe8AvxtiuMwx3w@xxxxxxxxxxxxxxxx> Sent by: ccnet-devel-admin-5NWGOfrQmneHXe+LvDLADg@xxxxxxxxxxxxxxxxxxxxxxxxxxxx 18/11/2004 03:39 Please respond to ccnet-devel

To:        ccnet-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@xxxxxxxxxxxxxxxx         cc:        Thomas Bolon <tbolon-6qIjVYSk/pbwW4y98TwLrg@xxxxxxxxxxxxxxxx>, (bcc: Owen Rogers/Canada/ThoughtWorks)         Subject:        Re: [Ccnet-devel] RegExp problem in VSSHistoryParser::ParseUsernameAndDate()

Here's a patch for CCNET-251, relying on Thomas' first
proposal, with
a unit test using data he provided to ensure we don't regress later.

I choosed to remove char 160 just like Thomas proposed, as it seems both
good
enough and simple, plus I suspect we may meet this situation
again with other non-english vss (no french exception here ?;). If we
discover it's not good enough we'll move on to the (slightly) more
complex solutions.


Owen, can you check this versus an english VSS ?


cheers

Thibaut





On Tue, 16 Nov 2004 16:41:10 +0100, Thomas Bolon <tbolon-6qIjVYSk/pbwW4y98TwLrg@xxxxxxxxxxxxxxxx>
wrote:
> I've created an issue on Jira for the bug, all information are included.
> 
> http://jira.public.thoughtworks.org/browse/CCNET-251
> 
> I've manually corrected this problem by removing any char(160) in
entry in
> the VSSParser ctor by using this line after the entry initialization
:
> 
> this.entry = this.entry.Replace(Convert.ToChar(160).ToString(), "");
> 
> I don't know if this solution is correct enough for a release build,
but in
> my case it removes problems without any other modification.
> 
> I've suggested a better correction in the issue on Jira.
> 
> Thanks for your work.
> 
> 
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by: InterSystems CACHE
> FREE OODBMS DOWNLOAD - A multidimensional database that combines
> robust object and relational technologies, making it a perfect match
> for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8
> _______________________________________________
> Ccnet-devel mailing list
> Ccnet-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@xxxxxxxxxxxxxxxx
> https://lists.sourceforge.net/lists/listinfo/ccnet-devel
>

ccnet-251.patch
Description: Binary data