[ wix-Bugs-1294976 ] Decompiler codepage problem

Bugs item #1294976, was opened at 2005-09-18 20:36
Message generated for change (Comment added) made by derekc
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1294976&group_id=105970

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: dark
Group: v3.0
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: bnk (nbelyh)
Assigned to: Derek (derekc)
>Summary: Decompiler codepage problem

Initial Comment:
If setup is not in english, 
then linker outputs question marks to the tables instead 
of real strings...

The output codepage is set only if localization is in effect; 
thus, for non-english setups, the codepage is set to 
ascii.

It seems that output codepage should be set to one 
specified in the input file, even when there is no 
localization file specified... or am I missing something?

I'v run into this problem by de-compiling existing (non-
english) setup, and then trying to compile it with wix.

The fix may be setting output.CodePage in Linker.cs to 
value specified in input file..
or adding extra parameter to linker to specify output 
codepage...

Thanks.

----------------------------------------------------------------------

>Comment By: Derek (derekc)
Date: 2006-02-24 00:17

Message:
Logged In: YES 
user_id=518766

The 3.0 version of dark handles this case properly - the fix
will not be ported back to 2.0.  Please use the 3.0
decompiler instead.

----------------------------------------------------------------------

Comment By: Rob Mensching (robmen)
Date: 2006-02-22 00:06

Message:
Logged In: YES 
user_id=991639

Moving to WiX v3 where dark has been significantly 
revamped to handle things better.

----------------------------------------------------------------------

Comment By: bnk (nbelyh)
Date: 2005-09-19 07:45

Message:
Logged In: YES 
user_id=1199354

OK, I see. Indeed, Product/@Codepage was lost after 
decompiling.. if added, everything works just fine :)

Thank you for comments..

----------------------------------------------------------------------

Comment By: Derek (derekc)
Date: 2005-09-19 00:58

Message:
Logged In: YES 
user_id=518766

The codepage can be set without using the localization
files, just set Product/@Codepage.

The excellent bug description helped me find that there is a
bug here: the decompiler does not seem to set the codepage
for the msi.  I'm assigning this to Robert to handle the
decompiler issue (which should be fixed in both WiX 2.0 and
3.0).

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1294976&group_id=105970


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642