[ wix-Bugs-1432746 ] Attribute "locfile" of NAntTasks's LightTask needs quoting

Bugs item #1432746, was opened at 2006-02-16 02:13
Message generated for change (Settings changed) made by robmen
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1432746&group_id=105970

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: v2.0
>Status: Pending
>Resolution: Fixed
Priority: 5
Submitted By: Leon Zandman (lzandman)
>Assigned to: Rob Mensching (robmen)
Summary: Attribute "locfile" of NAntTasks's LightTask needs quoting

Initial Comment:
I've found a bug in the LightTask of the WiX NAntTasks.
If you specify a "locfile" attribute in a LightTask and
set the value to a path containing spaces the build
will fail. This happens because the value of the
"locfile" attribute is injected wrongly into the
light.exe command-line. So if you specify the following
in your NAnt build file (only relevant portions included):

<light ... locfile="My Project\test.wxl" ... />

it will translate to:

light.exe -loc My Project\test.wxl ...

This will ofcourse fail, because "My Project" contains
a space character and Light will see "My" and
"Project\test.wxl" as two separate parameters. The -loc
value has to be quoted, like this:

light.exe -loc "My Project\test.wxl" ...

The solution is a minor change in "LightTask.cs". In
the WriteOptions() method the line:

writer.WriteLine("-loc {0}", this.LocFile);

has to be replaced by:

writer.WriteLine("-loc \"{0}\"", this.LocFile);


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1432746&group_id=105970


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642