logo       

Re: bugfix (#ifdef DEBUG) for short lived windows: msg#00161

window-managers.sawfish

Subject: Re: bugfix (#ifdef DEBUG) for short lived windows

Michal Maru¹ka writes:
|add_window() should contain:
|+ w->name = rep_null_string ();
|
|because the 1st X call (which is _before_ XGetWMName), can cause the
|error_handler call: DB(("error_handler (%s)\n", rep_STR(w->name)));
|and 0 is not valid for rep_STR.

thanks, I committed this

|
|Also, i'm not sure if an infinite cycle is avoided (when closing windows):
|
|remove_window() makes some X calls, which (if the X window is already gone),
|can trigger error_handler, which calls remove_window.

the from_error parameter is true when called from the error handler,
this tells remove_window that it shouldn't generate any X requests. If
it does, that's a bug,

John





<Prev in Thread] Current Thread [Next in Thread>
Google Custom Search

News | FAQ | advertise