|
Re: bugfix (#ifdef DEBUG) for short lived windows: msg#00161window-managers.sawfish
Michal Maru¹ka writes: |add_window() should contain: |+ w->name = rep_null_string (); | |because the 1st X call (which is _before_ XGetWMName), can cause the |error_handler call: DB(("error_handler (%s)\n", rep_STR(w->name))); |and 0 is not valid for rep_STR. thanks, I committed this | |Also, i'm not sure if an infinite cycle is avoided (when closing windows): | |remove_window() makes some X calls, which (if the X window is already gone), |can trigger error_handler, which calls remove_window. the from_error parameter is true when called from the error handler, this tells remove_window that it shouldn't generate any X requests. If it does, that's a bug, John |
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| Previous by Date: | bugfix (#ifdef DEBUG) for short lived windows: 00161, Michal Maruška |
|---|---|
| Next by Date: | Re: Sawfish and Gnome 2.2: 00161, John Harper |
| Previous by Thread: | bugfix (#ifdef DEBUG) for short lived windowsi: 00161, Michal Maruška |
| Next by Thread: | 经理人如何舒缓工作压力: 00161, |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
| News | FAQ | advertise |