Re: Patch for testbrowser.py

On Fri, Apr 21, 2006 at 12:17:37AM +0200, Philipp von Weitershausen wrote:
> Daniel Nouri wrote:
> > This patch adds 'Set-Cache' headers to the headers that are forwarded to
> > PublisherResponse.  Before, these headers would be suppressed.
> > 
> > 
> > Index: testbrowser.py
> > ===================================================================
> > --- testbrowser.py      (revision 66810)
> > +++ testbrowser.py      (working copy)
> > @@ -35,6 +35,7 @@
> >          headers.sort()
> >          headers.insert(0, ('Status', "%s %s" % (status, reason)))
> >          headers = '\r\n'.join('%s: %s' % h for h in headers)
> > +        headers += '\r\n' + '\r\n'.join(real_response._cookie_list())
> >          content = real_response.body
> >          return testing.PublisherResponse(content, headers, status, reason)
> > 
> 
> Brian,
> 
> since you added Five.testbrowser, perhaps you can say something about
> this patch and, if you think it's sound, apply it to 1.4 and the trunk?

Thanks for kicking me on this, I've been meaning to reply a for a while.

I think the best principle for the testbrowser in Five would be to keep
it as close to the Zope3 one as possible. As we would probably want to
merge the two if Zope2 uses the Zope3 publisher.

To be honest I am not enough into the zen of publishers to know the
answer but I don't see any analogue in the Zope3 testbrowser. I'm CC'ing
Z3-dev to see if anyone there knows better.

-- 
Brian Sutherland

Metropolis - "it's the first movie with a robot. And she's a woman.
              And she's EVIL!!"