Re: non breaking spaces added at the top of the pages ...

On Thursday, December 11, 2003, at 03:15  pm, Arnaud Fontaine wrote:

> Le lun 08/12/2003 à 10:57, Arnaud Fontaine a écrit :
> > On a wiki running PhpWiki 1.3.6, I've a nice little bug :
> >
> > On some nodes (not all) the diff action adds some nbsp at the very
> > beginning of the generated html page.
> >
> > I first thought it was a problem with the theme I write but it's the
> > same with "default".
> >
> > More : the number of nbsp is not always the same depending of the  
> > page.
> >
> > Have a look at  
> > http://innovation.crao.net/index.php/Accueil?action=diff
>
> It seems no one is interested in this bug ... bug when I check the
> source code of this page, it starts by :
>
>            &nbsp 
> ;&nbsp;&nbsp;<?xml version="1.0" encoding="iso-8859-1"?>
>
> This makes the page not a valid xml page ... and breaks some browsers.
> --
> Arnaud Fontaine
> Jabber: shinobi@xxxxxxxxxxxxxx
> ICQ: 3504789

Hi,
I already found the bug in lib/diff.php but there are a few other  
changes I would like make in there before I commit a proper repair to  
CVS. Here's a patch as a temporary workaround:

Index: diff.php
===================================================================
RCS file: /cvsroot/phpwiki/phpwiki/lib/diff.php,v
retrieving revision 1.44
diff -U2 -r1.44 diff.php
--- diff.php    17 Feb 2003 02:17:31 -0000      1.44
+++ diff.php    11 Dec 2003 20:46:39 -0000
@@ -49,5 +49,5 @@
                 continue;
             if ($word[0] == "\n") {
-                $this->_group .= PrintXML(HTML::raw('&nbsp;'));
+                $this->_group .= " "; //new RawXml('&nbsp;'); //FIXME:  
asXML(HTML::raw('&nbsp;')) ???
                 $this->_flushLine($tag);
                 $word = substr($word, 1);



-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?  SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/