logo       

Re: FTP "SYST" NULL dereferencing crash (found by someone else): msg#00034

web.wget.patches

Subject: Re: FTP "SYST" NULL dereferencing crash (found by someone else)

From: Ulf Harnhammar <metaur@xxxxxxxxx>

+ if (request == NULL)
+ {
+ xfree (respline);
+ return FTPSRVERR;
+ }

Well, yeah, if you prefer returning an error code to trying a little
harder. I prefer my change:

if (request == NULL)
*server_type = ST_OTHER;

Why punish the user when the FTP server behaves badly?

------------------------------------------------------------------------

Steven M. Schweda sms@antinode-org
382 South Warwick Street (+1) 651-699-9818
Saint Paul MN 55105-2547



<Prev in Thread] Current Thread [Next in Thread>
Google Custom Search

News | FAQ | advertise