Re: Broken FCGI Authorizer Mode in 1.3.0

On Mon, Sep 20, 2004 at 10:04:46PM -0500, Matt Levine wrote:
> fcgi authorizer mode in 1.3.0 makes lighttpd go into an endless loop, 
> here's the culprit (I think):
> 
> In fcgi_connection_cleanup():
> 
>       if (con->mode != p->id) return;
> 
> 
> In fcgi_handle_fdevent
> 
> we have:
> 
> if (hctx->host->mode == FCGI_AUTHORIZER && con->http_status == 200) {
> con->mode = DIRECT;
> 
> 
> so now con->mode != p->id
> 
> 
> and the connection never gets cleaned up, and chaos ensues.
> 
> 
> my fix is adding:
> 
> p->id = con->mode;
> 
> inside the if statement above.
 
I fixed it slightly different, but the effect is the same. Hmm, the
problem should exists since a few more releases.

1.3.1 will include the fix.
 
 
    Jan
  
-- 
Jan Kneschke                                     http://jan.kneschke.de/
Perhaps you want to say 'thank you, jan':    http://jk.123.org/wishlist/