Re: Icons checked in with faulty transparency settings

On Wed, 2005-03-30 at 18:10 +0200, Guido Wesdorp wrote:
> Hi!
> 
> A couple of images just got checked in (icons for image and table, iirc 
> by Donovan), and it looks like they don't have transparency properly 
> set, since they get little borders when used against a background that 
> is not gray. Also they are somewhat inconsistent with the rest (although 
> I don't mind that so much, perhaps we should even make the rest 
> inconsistent with those new ones?)...

Sorry about that... I stuffed up when converting from gif's... I
realised this after I committed, and didn't get a chance to fix it until
the next day.

I've fixed the transparency, and shrunk them heaps by reducing the
pallet to 32 colors. Let me know if they are OK now... 

They should be fairly consistent with the existing icons... ie 20x20,
similar colors etc, though they might be slightly larger... I cropped
them from 23x22 gifs (the old epoz icon size), so they have only a
1pixel left/top/bottom border and 2pixel right border.

Actually... is there a particular reason why the existing icons have
such large borders? For example bold.png has borders of 5 and 6 pixels,
so the "B" only uses 9x9 of the 20x20 image.

> What do you guys think we should do? Remove the new ones again? Fix 
> transparency and leave it like it is? Change the rest too?

I thought they were significantly better than the old image/table icons,
but accept that this is a subjective opinion... feel free to revert them
if you think the old ones were better.

I also cleaned up heaps of old gif's that are not used anywhere
anymore... part of that commit was changing the roundup flavour to use
the new png icons used everywhere else... it looked like it hadn't been
updated rather than a conscious decision to use gif's instead of png's.

The remaining gif's in common/kupuimages either don't have a png
replacement, or are still used somewhere. 

In particular, the plone flavour still has references to bold.gif,
italic.gif, underline.gif, and indent.gif. This may be something that
needs fixing in the plone flavor... it has copies of all the old gifs in
plone/kupu_plone_layer/plonekupuimages/ and mostly references these,
except in the case of the above gifs.

-- 
Donovan Baarda <abo@xxxxxxxxxxxxxxx>
Obsidian Consulting Group