logo       

some minor TableTool issues: msg#00026

web.kupu.devel

Subject: some minor TableTool issues

Hi!


1.) table element attributes
----------------------------

createTable adds these attributes:

table.border = 1;
table.cellPadding = 8;
table.cellSpacing = 2;

_fixTableHelper resets these two attributes:

table.cellPadding = 0;
table.cellSpacing = 0;

This is at least inconsistent. Is there at all a need to set them? If not, I'd like to remove these lines in createTable and replace them with removeAttribute() calls in _fixTableHelper.


2.) hardcoded allowed_classes in _fixTableHelper
------------------------------------------------

I'd like to replace them with this.editor.config.table_classes['class'] and default to the first of these classes if there is a need to reset the class.


3.) _selectContentIfEmpty event handler
---------------------------------------

Is there a good reason why each cell has its own handler? Adding the handler to the table element would make it easier to add its behavior to new rows/cols.


Any thoughts?


Cheers,

Yuppie


<Prev in Thread] Current Thread [Next in Thread>
Google Custom Search

News | FAQ | advertise