[ tidy-Bugs-1236678 ] Compiling PHP 5.0.4 fails on `error: duplicate 'unsigned'`

Bugs item #1236678, was opened at 2005-07-12 06:02
Message generated for change (Comment added) made by terry_teague
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390963&aid=1236678&group_id=27659

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
>Category: Source portability
Group: Current - Mac OS specific
Status: Open
Resolution: None
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
>Assigned to: Terry Teague (terry_teague)
Summary: Compiling PHP 5.0.4 fails on `error: duplicate 'unsigned'`

Initial Comment:
PHP 5.0.4 fails to compile with tidylib version 'HTML Tidy for Mac OS X 
released on 1 July 2005'. System is g5 running OS X 10.4.1.

email: matt.hershberger@xxxxxxx

The tidy version included in 10.4 fails with the same error (error below) 
on line 515 of platform.h. I upgraded thinking that would solve the 
issue.

Tidy was compiled from cvs using:
./configure --prefix=/usr --includedir=/usr/include/tidy --libdir=/
usr/lib

PHP was compiled from source using: (same configure options as the 
php that ships with 10.4 with the addition of --with-tidy)
'./configure' '--prefix=/usr' '--mandir=/usr/share/man' '--infodir=/
usr/share/info' '--with-apxs' '--with-ldap=/usr' '--with-kerberos=/
usr' '--enable-cli' '--with-zlib-dir=/usr' '--enable-trans-sid' '--with-
xml' '--enable-exif' '--enable-ftp' '--enable-mbstring' '--enable-
mbregex' '--enable-dbx' '--enable-sockets' '--with-iodbc=/usr' '--
with-curl=/usr' '--with-config-file-path=/etc' '--sysconfdir=/private/
etc' '--with-tidy'

I was able to work around this problem by
commenting out line 508 of /usr/include/tidy/platform.h while 
compiling php. I uncommented line 508 after installation of php 
completed. Tidy works as expected from the command line and PHP.

I came across this bug (http://bugzilla.opendarwin.org/show_bug.cgi?
id=2993) on opendarwin.org that describes the issue I am having. 
However they closed it as fixed and the last comment
said it was a problem in tidy.

Here is the error message:
[snip]
In file included from /usr/include/tidy/tidy.h:70,
                 from /Users/matthewh/Downloads/php-5.0.4/ext/tidy/
tidy.c:37:
/usr/include/tidy/platform.h:508: error: duplicate 'unsigned'
/usr/include/tidy/platform.h:508: warning: useless type name in 
empty declaration
[/snip]

Here are a few more lines of output around the error:
[snip]
gcc  -Iext/tidy/ -I/Users/matthewh/Downloads/php-5.0.4/ext/tidy/ -
DPHP_ATOM_INC -I/Users/matthewh/Downloads/php-5.0.4/include -
I/Users/matthewh/Downloads/php-5.0.4/main -I/Users/matthewh/
Downloads/php-5.0.4 -I/usr/include/libxml2 -I/Users/matthewh/
Downloads/php-5.0.4/ext/mbstring/oniguruma -I/Users/matthewh/
Downloads/php-5.0.4/ext/mbstring/libmbfl -I/Users/matthewh/
Downloads/php-5.0.4/ext/mbstring/libmbfl/mbfl -I/usr/include/tidy 
-I/Users/matthewh/Downloads/php-5.0.4/TSRM -I/Users/matthewh/
Downloads/php-5.0.4/Zend  -no-cpp-precomp  -g -O2  -c /Users/
matthewh/Downloads/php-5.0.4/ext/tidy/tidy.c -o ext/tidy/tidy.o  && 
echo > ext/tidy/tidy.lo
In file included from /usr/include/tidy/tidy.h:70,
                 from /Users/matthewh/Downloads/php-5.0.4/ext/tidy/
tidy.c:37:
/usr/include/tidy/platform.h:508: error: duplicate 'unsigned'
/usr/include/tidy/platform.h:508: warning: useless type name in 
empty declaration
/Users/matthewh/Downloads/php-5.0.4/ext/tidy/tidy.c: In function 
'php_tidy_quick_repair':
/Users/matthewh/Downloads/php-5.0.4/ext/tidy/tidy.c:461: warning: 
pointer targets in initialization differ in signedness
/Users/matthewh/Downloads/php-5.0.4/ext/tidy/tidy.c: In function 
'tidy_doc_cast_handler':
/Users/matthewh/Downloads/php-5.0.4/ext/tidy/tidy.c:636: warning: 
pointer targets in initialization differ in signedness
/Users/matthewh/Downloads/php-5.0.4/ext/tidy/tidy.c: In function 
'tidy_node_cast_handler':
/Users/matthewh/Downloads/php-5.0.4/ext/tidy/tidy.c:668: warning: 
pointer targets in initialization differ in signedness
/Users/matthewh/Downloads/php-5.0.4/ext/tidy/tidy.c: In function 
'tidy_doc_update_properties':
/Users/matthewh/Downloads/php-5.0.4/ext/tidy/tidy.c:689: warning: 
pointer targets in initialization differ in signedness
/Users/matthewh/Downloads/php-5.0.4/ext/tidy/tidy.c:697: warning: 
pointer targets in initialization differ in signedness
/Users/matthewh/Downloads/php-5.0.4/ext/tidy/tidy.c: In function 
'zif_ob_tidyhandler':
/Users/matthewh/Downloads/php-5.0.4/ext/tidy/tidy.c:990: warning: 
pointer targets in initialization differ in signedness
/Users/matthewh/Downloads/php-5.0.4/ext/tidy/tidy.c: In function 
'zif_tidy_get_error_buffer':
/Users/matthewh/Downloads/php-5.0.4/ext/tidy/tidy.c:1039: 
warning: pointer targets in initialization differ in signedness
/Users/matthewh/Downloads/php-5.0.4/ext/tidy/tidy.c: In function 
'zif_tidy_get_output':
/Users/matthewh/Downloads/php-5.0.4/ext/tidy/tidy.c:1055: 
warning: pointer targets in initialization differ in signedness
make: *** [ext/tidy/tidy.lo] Error 1
[/snip]

----------------------------------------------------------------------

>Comment By: Terry Teague (terry_teague)
Date: 2005-08-28 17:27

Message:
Logged In: YES 
user_id=225318

Thanks for the report.

I don't usually build on Tiger, but last time I did build on Tiger with the 
latest code (Aug 2005), it compiled without problem, using my slightly 
customized version of the code and Makefile. I know of one other Tiger 
specific bug with the standard Tidy code/Makefile that I should fix in 
CVS.

I will investigate further and fix as appropriate.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390963&aid=1236678&group_id=27659


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf