Subject: RE: Re: eXosip weird code - msg#00216

Previous Message by Date: click to view message preview

Re: Where is "Cocoa/Cocoa.h"?

Yes, I am using the Chinese version Windows XP. But how can I solve this problem?Thanks for your guide.   Wanding.  On 9/21/06, Philippe BERNERY <philippe.bernery-7nadfV1f7FY@xxxxxxxxxxxxxxxx> wrote: Le 21 sept. 06 à 01:37, wanding wang a écrit : Tomi, could you please update your code to solve this issue? today when I build rev 7643, the error is still there.Thanks. Wanding.  Are you still talking about the Languages.h problem? If so, it could be a UTF-8 handling problem on your system.   -- Philippe BERNERY <philippe.bernery-7nadfV1f7FY@xxxxxxxxxxxxxxxx> http://dev.openwengo.org     _______________________________________________ Wengophone-devel mailing list Wengophone-devel-ZwoEplunGu1JKUZHOYzk1kEOCMrvLtNR@xxxxxxxxxxxxxxxx http://dev.openwengo.com/mailman/listinfo/wengophone-devel

Next Message by Date: click to view message preview

RE: Re: eXosip weird code

Hi Vadim, There was a little thing missing in your last commit. I fixed that in REV#7665 :) Minh > > Thanks Vadim! I forgot that there could be many dialogs in a call :) > > Minh > > > > Minh, > > > > I've fixed your fix in REV #7658 to scan all dialogs in the call > > > > Vadim > > > > > > > > > > > > > >>-----Original Message----- > > >>From: > > >>wengophone-devel-bounces-ZwoEplunGu1JKUZHOYzk1kEOCMrvLtNR@xxxxxxxxxxxxxxxx > > >> [mailto:wengophone- > > >>devel-bounces-ZwoEplunGu1JKUZHOYzk1kEOCMrvLtNR@xxxxxxxxxxxxxxxx] On > > >>Behalf Of Marlon Mircevski > > >>Sent: jeudi 21 septembre 2006 09:44 > > >>To: wengophone-devel-ZwoEplunGu1JKUZHOYzk1kEOCMrvLtNR@xxxxxxxxxxxxxxxx > > >>Subject: [Wengophone-devel] Re: eXosip weird code > > >> > > >>Marlon Mircevski wrote: > > >> > > >> > > >>>Can someone take a look at wifo\eXosip\src\misc.c, line 55 in func > > >>>eXosip_remove_transaction_from_call(osip_transaction_t *tr, > > >>>eXosip_call_t *jc) > > >>>i cannot understand why eXosip_dialog_t *jd is used without having > > >>>been initialized, maybe it's value can be from jc->c_dialogs? > > >>> > > >>> > > >>> > > >>Just take a look at old eXosip code, i think the following is missed: > > >>--- > > >>for (jd = jc->c_dialogs; jd != NULL; jd = jd->next) > > >> { > > >> int pos = 0; > > >> while (!osip_list_eol (jd->d_inc_trs, pos)) > > >> { > > >> osip_transaction_t *inc_tr = osip_list_get (jd->d_inc_trs, > > pos); > > >> if (inc_tr == tr) > > >> { > > >> osip_list_remove (jd->d_inc_trs, pos); > > >> return 0; > > >> } > > >> pos++; > > >> } > > >> } > > >>--- > > >>and > > >>--- > > >>for (jd = jc->c_dialogs; jd != NULL; jd = jd->next) > > >> { > > >> int pos = 0; > > >> while (!osip_list_eol (jd->d_out_trs, pos)) > > >> { > > >> osip_transaction_t *out_tr = osip_list_get (jd->d_out_trs, > > pos); > > >> if (out_tr == tr) > > >> { > > >> osip_list_remove (jd->d_out_trs, pos); > > >> return 0; > > >> } > > >> pos++; > > >> } > > >> } > > >>--- > > >> > > >>Marlon > > >> > > >>_______________________________________________ > > >>Wengophone-devel mailing list > > >>Wengophone-devel-ZwoEplunGu1JKUZHOYzk1kEOCMrvLtNR@xxxxxxxxxxxxxxxx > > >>http://dev.openwengo.com/mailman/listinfo/wengophone-devel > > >> > > >> > > > > > >_______________________________________________ > > >Wengophone-devel mailing list > > >Wengophone-devel-ZwoEplunGu1JKUZHOYzk1kEOCMrvLtNR@xxxxxxxxxxxxxxxx > > >http://dev.openwengo.com/mailman/listinfo/wengophone-devel > > > > > > > > > > > > > > _______________________________________________ > Wengophone-devel mailing list > Wengophone-devel-ZwoEplunGu1JKUZHOYzk1kEOCMrvLtNR@xxxxxxxxxxxxxxxx > http://dev.openwengo.com/mailman/listinfo/wengophone-devel

Previous Message by Thread: click to view message preview

Re: Re: eXosip weird code

Quang Minh Phan wrote: Hi Marlon, Thank you for reporting the bug. It was fixed in the svn. This line was added to initialize jd to the value of jc->c_dialogs as you expected: jd = jc->c_dialogs; just before this piece of code: if (jd) { if (!eXosip_list_remove_element(jd->d_inc_trs, tr)) return 0; if (!eXosip_list_remove_element(jd->d_out_trs, tr)) return 0; OSIP_TRACE(osip_trace(__FILE__,__LINE__,OSIP_INFO1,NULL, "eXosip: No information.\n")); } Regards, Minh Minh, I've fixed your fix in REV #7658 to scan all dialogs in the call Vadim -----Original Message----- From: wengophone-devel-bounces-ZwoEplunGu1JKUZHOYzk1kEOCMrvLtNR@xxxxxxxxxxxxxxxx [mailto:wengophone- devel-bounces-ZwoEplunGu1JKUZHOYzk1kEOCMrvLtNR@xxxxxxxxxxxxxxxx] On Behalf Of Marlon Mircevski Sent: jeudi 21 septembre 2006 09:44 To: wengophone-devel-ZwoEplunGu1JKUZHOYzk1kEOCMrvLtNR@xxxxxxxxxxxxxxxx Subject: [Wengophone-devel] Re: eXosip weird code Marlon Mircevski wrote: Can someone take a look at wifo\eXosip\src\misc.c, line 55 in func eXosip_remove_transaction_from_call(osip_transaction_t *tr, eXosip_call_t *jc) i cannot understand why eXosip_dialog_t *jd is used without having been initialized, maybe it's value can be from jc->c_dialogs? Just take a look at old eXosip code, i think the following is missed: --- for (jd = jc->c_dialogs; jd != NULL; jd = jd->next) { int pos = 0; while (!osip_list_eol (jd->d_inc_trs, pos)) { osip_transaction_t *inc_tr = osip_list_get (jd->d_inc_trs, pos); if (inc_tr == tr) { osip_list_remove (jd->d_inc_trs, pos); return 0; } pos++; } } --- and --- for (jd = jc->c_dialogs; jd != NULL; jd = jd->next) { int pos = 0; while (!osip_list_eol (jd->d_out_trs, pos)) { osip_transaction_t *out_tr = osip_list_get (jd->d_out_trs, pos); if (out_tr == tr) { osip_list_remove (jd->d_out_trs, pos); return 0; } pos++; } } --- Marlon _______________________________________________ Wengophone-devel mailing list Wengophone-devel-ZwoEplunGu1JKUZHOYzk1kEOCMrvLtNR@xxxxxxxxxxxxxxxx http://dev.openwengo.com/mailman/listinfo/wengophone-devel _______________________________________________ Wengophone-devel mailing list Wengophone-devel-ZwoEplunGu1JKUZHOYzk1kEOCMrvLtNR@xxxxxxxxxxxxxxxx http://dev.openwengo.com/mailman/listinfo/wengophone-devel

Next Message by Thread: click to view message preview

RE: Re: eXosip weird code

Hi Vadim, There was a little thing missing in your last commit. I fixed that in REV#7665 :) Minh > > Thanks Vadim! I forgot that there could be many dialogs in a call :) > > Minh > > > > Minh, > > > > I've fixed your fix in REV #7658 to scan all dialogs in the call > > > > Vadim > > > > > > > > > > > > > >>-----Original Message----- > > >>From: > > >>wengophone-devel-bounces-ZwoEplunGu1JKUZHOYzk1kEOCMrvLtNR@xxxxxxxxxxxxxxxx > > >> [mailto:wengophone- > > >>devel-bounces-ZwoEplunGu1JKUZHOYzk1kEOCMrvLtNR@xxxxxxxxxxxxxxxx] On > > >>Behalf Of Marlon Mircevski > > >>Sent: jeudi 21 septembre 2006 09:44 > > >>To: wengophone-devel-ZwoEplunGu1JKUZHOYzk1kEOCMrvLtNR@xxxxxxxxxxxxxxxx > > >>Subject: [Wengophone-devel] Re: eXosip weird code > > >> > > >>Marlon Mircevski wrote: > > >> > > >> > > >>>Can someone take a look at wifo\eXosip\src\misc.c, line 55 in func > > >>>eXosip_remove_transaction_from_call(osip_transaction_t *tr, > > >>>eXosip_call_t *jc) > > >>>i cannot understand why eXosip_dialog_t *jd is used without having > > >>>been initialized, maybe it's value can be from jc->c_dialogs? > > >>> > > >>> > > >>> > > >>Just take a look at old eXosip code, i think the following is missed: > > >>--- > > >>for (jd = jc->c_dialogs; jd != NULL; jd = jd->next) > > >> { > > >> int pos = 0; > > >> while (!osip_list_eol (jd->d_inc_trs, pos)) > > >> { > > >> osip_transaction_t *inc_tr = osip_list_get (jd->d_inc_trs, > > pos); > > >> if (inc_tr == tr) > > >> { > > >> osip_list_remove (jd->d_inc_trs, pos); > > >> return 0; > > >> } > > >> pos++; > > >> } > > >> } > > >>--- > > >>and > > >>--- > > >>for (jd = jc->c_dialogs; jd != NULL; jd = jd->next) > > >> { > > >> int pos = 0; > > >> while (!osip_list_eol (jd->d_out_trs, pos)) > > >> { > > >> osip_transaction_t *out_tr = osip_list_get (jd->d_out_trs, > > pos); > > >> if (out_tr == tr) > > >> { > > >> osip_list_remove (jd->d_out_trs, pos); > > >> return 0; > > >> } > > >> pos++; > > >> } > > >> } > > >>--- > > >> > > >>Marlon > > >> > > >>_______________________________________________ > > >>Wengophone-devel mailing list > > >>Wengophone-devel-ZwoEplunGu1JKUZHOYzk1kEOCMrvLtNR@xxxxxxxxxxxxxxxx > > >>http://dev.openwengo.com/mailman/listinfo/wengophone-devel > > >> > > >> > > > > > >_______________________________________________ > > >Wengophone-devel mailing list > > >Wengophone-devel-ZwoEplunGu1JKUZHOYzk1kEOCMrvLtNR@xxxxxxxxxxxxxxxx > > >http://dev.openwengo.com/mailman/listinfo/wengophone-devel > > > > > > > > > > > > > > _______________________________________________ > Wengophone-devel mailing list > Wengophone-devel-ZwoEplunGu1JKUZHOYzk1kEOCMrvLtNR@xxxxxxxxxxxxxxxx > http://dev.openwengo.com/mailman/listinfo/wengophone-devel