logo       

frame flag handling: msg#00109

video.xine.devel

Subject: frame flag handling

Hi,

I noticed that the frame flags which are passed to the port with the
get_frame() call are not stored inside the frame. This results in some
naughty problems like:
* VO_INTERLACED_FLAG being reset when the frame travels through post
plugins (outgoing frames of post plugins always have only
VO_BOTH_FIELDS set)
* duplicate frames always have just VO_BOTH_FIELDS flag (as hardcoded
in video_out.c), no matter what the original frame's flags were;
this confuses the dxr3 on some DVD stills, because the
VO_PAN_SCAN_FLAG would switch on and off when the duplicates are
made
I have a fix for that which I will commit tomorrow. I modified
vo_frame_t structure to add a flags member, but since we increased the
relevant API version numbers lately, I am not going to raise them
again. I hope noone minds that.

Michael

--
"Premature optimization is the root of all evil."
-Donald E. Knuth

Attachment: store-frame-flags.patch
Description: Text Data

<Prev in Thread] Current Thread [Next in Thread>
Google Custom Search

News | FAQ | advertise