Re: Small xine-ui inconsistency with loading subtitles

Hi,

I looked at the problem and it turned out to be easy to fix.
The fix fixes both my problems, patch is attached.
Will someone please review and (maybe) apply it into the current CVS?

Boszormenyi Zoltan wrote:
> Hi,
>
> there is a small problem that annoys me enough to talk about it. :-)
> I regularly use the right click menu of Xine-ui to load the movie file,
> and the subtitle file after that. The annoying thing is that the file
> dialog starts in my home directory, not in the directory that I loaded
> the last movie from. It is not uncommon that the subtitle and the movie
> file are in the same directory, so it would be logical to use the movie
> directory as the starting point for the subtitle.
>
> Also, if I press the "Close" button without selecting a subtitle file,
> the next time I want to load another movie and user the right click 
> menu, it starts from the same directory that the "Pick a subtitle file"
> window showed before. Is it considered a feature or a usability bug? :-)


--
Best regards,
Zoltán Böszörményi

---------------------
What did Hussein say about his knife?
One in Bush worth two in the hand.
--- xine-ui/src/xitk/actions.c.old      2003-08-06 12:04:04.000000000 +0200
+++ xine-ui/src/xitk/actions.c  2003-08-06 12:08:52.000000000 +0200
@@ -1793,7 +1793,9 @@
       cbb[0].need_a_file = 1;
       cbb[1].callback = fileselector_cancel_callback;
       cbb[1].need_a_file = 0;
-      (void *) create_filebrowser(_("Pick a subtitle file"), mmk->sub, 
&cbb[0], NULL, &cbb[1]);
+      (void *) create_filebrowser(_("Pick a subtitle file"),
+               (mmk->sub ? mmk->sub : mmk->mrl),
+               &cbb[0], NULL, &cbb[1]);
     }
   }
 }