Should bazaar generate its own revIDs?

Hi all,

I'm seeking a confirm on this patch by Ori from some bazaar expert: I
was about to push it on the master repo, but suddenly a little doubt
grew up :)

Tailor used to build its own revIDs at bazaar commit time: I don't
remember if there was a particular reasoning behind that, or if at the
time there wasn't a public API within bazaar for the task.

Thanks in advance,
ciao, lele.

--- Begin Message ---

Subject:	darcs patch: Resolved bzrlib deprecation warnings. Have bazaar gene...

Fri Oct  5 16:10:29 IST 2007  Ori Avtalion <ori@xxxxxxxxxxxxx>
  * Resolved bzrlib deprecation warnings. Have bazaar generate the revision-ids.
  1) add.smart_add_tree was deprecated in version 0.18.
  2) Unicode revision ids were deprecated in bzr 0.15. Revision id generators 
should be creating utf8 revision ids.
     Instead of encoding the revision id in utf8, it's simpler to have bzrlib 
generate it.

New patches:

[Resolved bzrlib deprecation warnings. Have bazaar generate the revision-ids.
Ori Avtalion <ori@xxxxxxxxxxxxx>**20071005141029
 1) add.smart_add_tree was deprecated in version 0.18.
 2) Unicode revision ids were deprecated in bzr 0.15. Revision id generators 
should be creating utf8 revision ids.
    Instead of encoding the revision id in utf8, it's simpler to have bzrlib 
generate it.
] {
hunk ./vcpx/repository/bzr.py 23
-from bzrlib.add import smart_add_tree
hunk ./vcpx/repository/bzr.py 234
-            smart_add_tree(self._working_tree, names, recurse=False)
+            self._working_tree.smart_add(names, recurse=False)
hunk ./vcpx/repository/bzr.py 238
-        added, ignored = smart_add_tree(self._working_tree, [subdir], 
recurse=True)
+        added, ignored = self._working_tree.smart_add([subdir], recurse=True)
hunk ./vcpx/repository/bzr.py 259
-        from bzrlib.osutils import compact_date, rand_bytes
hunk ./vcpx/repository/bzr.py 275
-        # Guess sane email address
-        email = search("<(.*@.*)>", author)
-        if email:
-            email = email.group(1)
-        else:
-            email = author
-        # Remove whitespace
-        email = ''.join(email.split())
-
hunk ./vcpx/repository/bzr.py 279
-        revision_id = "%s-%s-%s" % (email, compact_date(timestamp),
-                                    hexlify(rand_bytes(8)))
hunk ./vcpx/repository/bzr.py 280
-                                  specific_files=entries, rev_id=revision_id,
+                                  specific_files=entries,
}

Context:

[test suite windows path correction
techtonik@xxxxxxx**20070725185553] 
[Fix #82: put all loggers at DEBUG level when --debug is given
lele@xxxxxxxxxxxxxxxxxxx**20070721215108] 
[Added --non-interactive to svn log calls
lele@xxxxxxxxxxxxxxxxxxx**20070721092358] 
[Reworked patch from docelic, to filter out missing CVS files
lele@xxxxxxxxxxxxxxxxxxx**20070717151540] 
[Try to fix CVS edge case, with two changesets with same timestamp
lele@xxxxxxxxxxxxxxxxxxx**20070716150058] 
[Take into account entries too in changeset comparison
lele@xxxxxxxxxxxxxxxxxxx**20070716150006] 
[git no-change commit check
bruce.stephens@xxxxxxxxx**20070513210159] 
[git email should use name
bruce.stephens@xxxxxxxxx**20070513210445] 
[[test-scripts] New tests: Darcs self testings for directories
henry@xxxxxxxxxx**20070711080712] 
[[test-scripts] New test: Monotone to Subversion rename directories and back to 
old name
henry@xxxxxxxxxx**20070711080506] 
[TAG Version 0.9.29
lele@xxxxxxxxxxxxxxxxxxx**20070710164830] 
Patch bundle hash:
312cbd0d015545ef1ebf08a436db8ebbcca4b876

--- End Message ---

_______________________________________________
Tailor mailing list
Tailor@xxxxxxxxxxxxxxx
http://lists.zooko.com/mailman/listinfo/tailor