svn commit: r13171 - trunk/subversion/libsvn_ra_svn

Author: rooneg
Date: Sat Feb 26 08:07:54 2005
New Revision: 13171

Modified:
   trunk/subversion/libsvn_ra_svn/client.c
Log:
Don't break out early when reading log entries from a server that is old
enough to not understand the 'svn log --limit' feature.  If we break out
early it means the RA session is rendered useless, and while that's not
a big deal for people using it via the libsvn_client interfaces it is a
problem for those using the lower level RA interface, like SVK does.

This makes libsvn_ra_svn use the same strategy as libsvn_ra_dav does for
working with old servers, and while it's annoying that it requires us to
read all the data over the network it is technically more correct.

* subversion/libsvn_ra_svn/client.c
  (ra_svn_log): don't bail when we go past the number of log entries we
   expected to get back, instead just stop passing them to the callback.

Reported By: clkao


Modified: trunk/subversion/libsvn_ra_svn/client.c
Url: 
http://svn.collab.net/viewcvs/svn/trunk/subversion/libsvn_ra_svn/client.c?view=diff&rev=13171&p1=trunk/subversion/libsvn_ra_svn/client.c&r1=13170&p2=trunk/subversion/libsvn_ra_svn/client.c&r2=13171
==============================================================================
--- trunk/subversion/libsvn_ra_svn/client.c     (original)
+++ trunk/subversion/libsvn_ra_svn/client.c     Sat Feb 26 08:07:54 2005
@@ -1105,11 +1105,10 @@
       else
         cphash = NULL;
 
-      if (limit && ++nreceived > limit)
-        break;
+      if (! (limit && ++nreceived > limit))
+        SVN_ERR(receiver(receiver_baton, cphash, rev, author, date, message,
+                         subpool));
 
-      SVN_ERR(receiver(receiver_baton, cphash, rev, author, date, message,
-                       subpool));
       apr_pool_clear(subpool);
     }
   apr_pool_destroy(subpool);