Subject: Re: [Subclipse-dev] open resource from change path list - msg#00088

Previous Message by Date: click to view message preview

Re: [Subclipse-dev] open resource from change path list

Mark Phippard wrote: I would like to see searching/filtering of log messages added. I'm not sure how filtering could look like, but I can take a look on search. I was thinking two things for filtering. 1) Say you have a bunch of revisions loaded. A search option could search the data that is loaded, and filter the view to only show the matches. 2) Some new options on the view to grab a specific set of messages, such as between dates X and Y. An idea might be to change the Show in Resource History action to first display a dialog that lets the user indicate how many messages to fetch and/or a date range for the messages. Just thinking out loud. Mark, for CVS integration this functionality is actually provided by special "date tags" and Synchronize view. You can create date tag in CVS repository view and then compare it with another date tag. Comparison results are shown in synchronize view. There is an overlap in functionality that is already provided by svn history view and what cvs sync view provide in "Commit Sets" mode. To maintain user experience it make sense to do it the same way for svn. That, however, will require to support "commit sets" feature for SVN syncronize view. Perhaps more compare options or other features such as initiating a reverse merge to back out a revision. I was mainly thinking about: a) make compare enabled in more circumnstances. Currently, you can only do compare if you are showing the revisions for a specific file. So, if history view shows folder it should bring up folder comparison then? b) perhaps provide a few compare options. Such as showing the specific change for that revision (probably in diff format). Comparing against the local pristine copy vs. the local edited copy. Perhaps options to show unified diff of the entire revision? Like a patch option? I presume that I can look at quick diff implementation to see what API to use for diff with pristine copy? By the way, current repository properies dialod doesn't allow to see URL if label had been changes. I add some static non editable label that will show this URL to this dialog. What do you think? I think that is a good idea. Please send a patch. Will do this tonight. regards, Eugene

Next Message by Date: click to view message preview

Re: [Subclipse-dev] open resource from change path list

Mark Phippard wrote: It has two cylinders comparing with 3 for CVS repository. Plus it has some "strange" frame on the back. None of SVN or CVS icons has such frame and I have difficult time to explain even to myself what this frame symbolyse. :-) I removed one of the the cylinders so that the icon would be less crowded and looked better. There was never anything significant about the use of 3, it was just trying to convey plurality, which 2 does just as well. The frame in the background is the generic Eclipse icon for a view.   Mark, I know all of that. It is just not very intuitive for the user who see these icons for the first time. Also, when svn will be as widely used in Eclipse community as cvs I guess users will express more confusion then now. From other hand most of the community just doesn't care about icons as long as functionality is there. :-) This is not quite appropriate. Especially for the users who installing plugins with update manager. Also, I believe that in a future Subclipse plugins will be packaged as jars and not expanded folders (this is available since 3.0) I could argue just as easily that the existing icon looked great and was not an issue for anyone but you. So if you have a problem with it, then you could replace it in your installation of Subclipse and update it when needed. As it stands, the icon I committed also looks good and satisifies your need for it to be different.   Right. But you have again ignored my question about another icon I've sugested. :-)   regards,   Eugene

Previous Message by Thread: click to view message preview

Re: [Subclipse-dev] open resource from change path list

Mark Phippard wrote: I would like to see searching/filtering of log messages added. I'm not sure how filtering could look like, but I can take a look on search. I was thinking two things for filtering. 1) Say you have a bunch of revisions loaded. A search option could search the data that is loaded, and filter the view to only show the matches. 2) Some new options on the view to grab a specific set of messages, such as between dates X and Y. An idea might be to change the Show in Resource History action to first display a dialog that lets the user indicate how many messages to fetch and/or a date range for the messages. Just thinking out loud. Mark, for CVS integration this functionality is actually provided by special "date tags" and Synchronize view. You can create date tag in CVS repository view and then compare it with another date tag. Comparison results are shown in synchronize view. There is an overlap in functionality that is already provided by svn history view and what cvs sync view provide in "Commit Sets" mode. To maintain user experience it make sense to do it the same way for svn. That, however, will require to support "commit sets" feature for SVN syncronize view. Perhaps more compare options or other features such as initiating a reverse merge to back out a revision. I was mainly thinking about: a) make compare enabled in more circumnstances. Currently, you can only do compare if you are showing the revisions for a specific file. So, if history view shows folder it should bring up folder comparison then? b) perhaps provide a few compare options. Such as showing the specific change for that revision (probably in diff format). Comparing against the local pristine copy vs. the local edited copy. Perhaps options to show unified diff of the entire revision? Like a patch option? I presume that I can look at quick diff implementation to see what API to use for diff with pristine copy? By the way, current repository properies dialod doesn't allow to see URL if label had been changes. I add some static non editable label that will show this URL to this dialog. What do you think? I think that is a good idea. Please send a patch. Will do this tonight. regards, Eugene

Next Message by Thread: click to view message preview

Re: [Subclipse-dev] open resource from change path list

Mark Phippard wrote: Mark, for CVS integration this functionality is actually provided by special "date tags" and Synchronize view. You can create date tag in CVS repository view and then compare it with another date tag. Comparison results are shown in synchronize view. There is an overlap in functionality that is already provided by svn history view and what cvs sync view provide in "Commit Sets" mode. To maintain user experience it make sense to do it the same way for svn. That, however, will require to support "commit sets" feature for SVN syncronize view. I don't agree. I think it makes sense to do it the way that is supported by Subversion, and that is to provide dates as inputs to the revision parms on the svn log command. The existing client adapter API should already support this. This is something we could implement in our existing view and would be the expected Subversion behavior. Well, Subclipse could provide both options - from history and from synchronize view. I'm sure that long-time CVS users will appreciate that. Note that sync view is more persistent then history and already provide more then one panel. History view can be also linked with the editor (well, may it is just me again) and when user switch to other editor its content will be refreshed. This aren't going to happend with sync view. I have itch to get an update action from history view, but it would be really better to implement sync view features like commit sets. Currently I feel blind looking at svn sync view in incoming changes mode, so I have to run svn history for the whole project in order to see what was going on with the project, but it is not quite the same, because I can't run update from history view and it is also show too many changes (sync view in cvs show changes from the head up to local revision). a) make compare enabled in more circumnstances. Currently, you can only do compare if you are showing the revisions for a specific file. So, if history view shows folder it should bring up folder comparison then? I was more thinking just that the compare options should be enabled. Ideally you could select a file from the affected paths list and compare it with the working copy. Right b) perhaps provide a few compare options. Such as showing the specific change for that revision (probably in diff format). Comparing against the local pristine copy vs. the local edited copy. Perhaps options to show unified diff of the entire revision? Like a patch option? I presume that I can look at quick diff implementation to see what API to use for diff with pristine copy? I am not really sure. Presumable the Compare with -> Base revision does this too? Does "compare with base revision" actually comares with pristine copy? regards, Eugene