In message <429BD75B.1080701@xxxxxxxxxxxxx> on Mon, 30 May 2005 21:17:47 -0600,
Derek Scherger <derek@xxxxxxxxxxxxx> said:
derek> Richard Levitte - VMS Whacker wrote:
derek> > I've a couple of gripes that I need to share:
derek> >
derek> > 1. 'monotone update' still takes an optional argument. Is there any
derek> > reason why it doesn't use --revision like all the others? If noone
derek> > minds a change to using --revision, I've a change ready to be
derek> > commited.
derek>
derek> No reason, other than --revision wasn't around at the time that
derek> was added probably.
Sounds like a good reason for me to push the change I did. :-)
derek> There are probably a few other commands that should be using
derek> options rather than arguments as well. At a glance:
derek>
derek> - genkey/dropkey/chkeypass/pubkey/privkey should probably use
derek> --key and we've got to be able to improve on the name of
derek> chkeypass ;)
Mmmm, I dunno. For those, the key ID is a mandatory argument, and it
doesn't feel right to make them an option (options should be optional,
at least in a general sense, see?)...
derek> - cert/trusted/tag/testresult/approve/disapprove should use
derek> --revision
Except, again, it's mandatory or central to them.
derek> - comment should probably use both --revision and --message
I could agree about --message, but again, the revision ID is
mandatory...
derek> - fcommit should use --revision (or be removed entirely)
Agina, a mandatory argument. Had you said that it should take a
--message, I would have agreed with you entirely :-).
derek> - not sure what to do with cat but it appears to need help
Same thing there...
derek> - cdiff could be replaced with an option to diff (--context and
derek> --unified perhaps)
Oh, I so agree with you! :-)
derek> > 2. Why on earth does everyone insist on putting all those
derek> > random [--revision=REVISION] and other options in the
derek> > arguments help for the command when those options are
derek> > already explained above the command help? The commands
derek> > currently having that kind of extra
derek>
derek> Guilty as charged :)
derek>
derek> With command specific options and associated help I agree that
derek> these are redundant.
I take that as encouragement to fix it :-).
Cheers,
Richard
-----
Please consider sponsoring my work on free software.
See http://www.free.lp.se/sponsoring.html for details.
--
Richard Levitte richard@xxxxxxxxxxx
http://richard.levitte.org/
"When I became a man I put away childish things, including
the fear of childishness and the desire to be very grown up."
-- C.S. Lewis
|
