logo       
Google Custom Search
    AddThis Social Bookmark Button
-->

Re: [issue84] tag command doesn't check tags for embedded newlines: msg#00544

Subject: Re: [issue84] tag command doesn't check tags for embedded newlines
On 11/29/05, Benoit Boissinot <bboissin@xxxxxxxxx> wrote:
> On 11/29/05, Bryan O'Sullivan <mercurial-bugs@xxxxxxxxxxx> wrote:
> >
> > New submission from Bryan O'Sullivan <bos@xxxxxxxxxxxxxx>:
> >
> > The tag command should either forbid embedded \r and \n characters, or 
> > escape
> > them so that they can be unescaped by localrepo.tags.  Right now, it does
> > nothing, so a command like this will corrupt the .hgtags file:
> >
> > hg tag 'foo
> > bar'
>
> patch that disallow '\n' and '\r' is attached,

i should always re-run the tests, corrected patch is attached
(test-tag didn't return 0)

sorry,

Benoit

Attachment: export.diff
Description: Text Data


<Prev in Thread] Current Thread [Next in Thread>