-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Bruno Haible wrote:
|> Do you still see some nits that could be improved?
|
|
| Oops, there was one more nit: The error messages were not
| internationalized. I did this:
[snip]
| *************** *** 129,135 **** { fd = open ("/dev/zero",
| O_RDONLY, 0666); if (fd < 0) ! error (EXIT_FAILURE, errno, "Failed
| to open /dev/zero for read"); } # endif /* HAVE_MAP_ANONYMOUS */
| ret = mmap (NULL, size, PROT_READ | PROT_WRITE, flags, fd, 0); ---
| 132,138 ---- { fd = open ("/dev/zero", O_RDONLY, 0666); if (fd < 0)
| ! error (EXIT_FAILURE, errno, _("Failed to open /dev/zero for
| read")); } # endif /* HAVE_MAP_ANONYMOUS */ ret = mmap (NULL, size,
| PROT_READ | PROT_WRITE, flags, fd, 0);
Should this error still be exiting (EXIT_FAILURE) when this function
is defined to return NULL on failure?
Regards,
Derek
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (Cygwin)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFCJ0j/LD1OTBfyMaQRAtohAJ9eNQ/a2dO1wXrfdw4WKfztB5UTzwCgjPdP
F3Y6HTeZBnfMFD6SZ5AdOqQ=
=zhqn
-----END PGP SIGNATURE-----
|
