On Thu, 15 Jul 2004, Brendan J Simon wrote:
> John Darrington wrote:
>
> >Some houses insist that code be reviewed by at least 2 persons.
> >Maybe aerpass could be made to simply increment a count which has to
> >go beyond a certain threshold before the change goes to the
> >awaiting_integration state.
> >
> >
> review_pass_count starts at x (eg. 2).
> It decrements with each review pass.
> It moves to integartion state when review_pass_count == 0
>
> Same thing but I think it is more efficient to code this way.
>
Yes and it also might allow the "heirarchy" in a sense. If one could
assign a "level" value to reviewers ala:
$ ael rev
project-guru 4
grand-hacker 2
apprentice 1
novice 0
Then a config variable says a change needs some value minimum to pass
review_pass_points_required = 2;
aede sets the changes points_required to the config value
aerp code deducts the reviewers value from the points required and if it
drops to or below 0 the change passes.
points_required -= reviewer_points;
It would then require 2 apprentices or 1 hacker|guru to review.
Note that if novice runs aerpass 0 would be deducted, thus having no
affect but still allowing them to review.
I also believe that the "who can review who's changes" could be
implemented simply by condidering the change developers 'level' ala:
review_strength = reviewer_points - developer_points;
if( review_strength > 0 ) points_required -= review_strength;
And again if (points_required <= 0 ) pass
Thus novice has no power to pass anyone,
2 apprentice[s] can pass novice but none other,
grand_hacker can review apprentice and novice but not each other,
And guru can review anyone. If guru level were 3 instead of 4 it would
require 2 gurus to pass a grand_hackers change.
Peter, what do you think?
--
Jerry Pendergraft jerry.pendergraft@xxxxxxxxxxxxxxx
Endocardial Solutions voice: 651-523-6935
1350 Energy Lane, Suite 110 fax: 651-644-7897
St Paul, MN 55108-5254 mobile: 651-491-0163
> Cheers,
> Brendan Simon.
>
> _______________________________________________
> Aegis-users mailing list
> Aegis-users@xxxxxxxxxxx
> http://www.auug.org.au/mailman/listinfo/aegis-users
>
|
