logo       

[chromium-reviews] Re: Add GrabWindowSnapshot method to mac_util class. Th: msg#01493

ubuntu-announce

Subject: [chromium-reviews] Re: Add GrabWindowSnapshot method to mac_util class. This code is due to dmaclac...



http://codereview.chromium.org/333018/diff/7001/2002
File base/mac_util.mm (right):

http://codereview.chromium.org/333018/diff/7001/2002#newcode171
Line 171: // Make sure to grab the "window frame" view so we get all
tabs.
"all the tabs." or "get the tabstrip."

http://codereview.chromium.org/333018/diff/7001/2002#newcode177
Line 177: const unsigned char* buf = static_cast<const unsigned
char*>([data bytes]);
should probably check to make sure that data is non-nil before
proceeding into the stl stuff. Do you care about the failure case?

http://codereview.chromium.org/333018

<Prev in Thread] Current Thread [Next in Thread>
Google Custom Search

News | FAQ | advertise