Re: Patch tv_grab_no

On Wed, 17 Nov 2004 14:20:48 -0800 (PST), Robert Eden <rmeden@xxxxxxxxx> wrote:
> I've applied the patch, committed the change to CVS and generated a new
> alpha-exe.
> 

Hm, looks like the script behaves differently on linux and windows.
The new alpha-exe exits with an error.

----8<---------------------------------
D:\xmltv-0.5.36-win32>xmltv.exe tv_grab_no --configure
Timezone is +0100
using config filename ./.xmltv/tv_grab_no.conf
The configuration file ./.xmltv/tv_grab_no.conf
already exists.  There is currently no support for altering an
existing configuration: you have to reconfigure from scratch.

Do you wish to overwrite the old configuration? [yes,no (default=no)] yes
getting list of channels: no channels could be found at /PerlApp/grab/no/tv_grab
_no line 175, <STDIN> line 1.
----8<---------------------------------

This is the part from tv_grab_no that causes the problem. The
returned hash %channels is empty when using win32. Any suggestions
why?

# get channel listing
sub get_channels {
    my $page = 
tidy(get_nice('http://fredag.dagbladet.no/tv/select_channels.html'));
    my @chanarray = split(/<input/, $page);
    my %channels;
    foreach my $item (@chanarray) {
        # $channels{$channel_id} = $channel_name;
        $channels{$1} = $2 if $item =~ /value=\"([0-9]+)\".*\">(.*)<\/label>/;
    }
    return %channels;
}


I have attached a patch that adds some needed error checking. I hope
it can be committed to CVS together with a fix to the win32 problem.


Regards,
Petter

tv_grab_no-rev1.13.diff
Description: Binary data