[jira] Created: (XMLBEANS-348) 2 Dubious assignments, probably should be equality tests

2 Dubious assignments, probably should be equality tests
--------------------------------------------------------

                 Key: XMLBEANS-348
                 URL: https://issues.apache.org/jira/browse/XMLBEANS-348
             Project: XMLBeans
          Issue Type: Bug
    Affects Versions:  Version 2.3
         Environment: n/a
            Reporter: Charles Butterfield


While peeking at the source code to report bug XMLBEANS-347, I (or rather the 
compiler) ran across two dubious assignments that were probably meant to be 
equality tests as shown below:

1) org.apache.xmlbeans.impl.common.XPath: line 717:

                       if ((_lastDeepDot = deepDot))

NOTE: if this really is meant to be an assignment, then the following 
conditional "_lastDeepDot = true;" is clearly
redundant, which helped me conclude this is a bug, rather than an evil combined 
assignment and test.


2) org.apache.xmlbeans.impl.schema.SchemaTypeSystemImpl: line 756:

                              assert assertEnabled = true;

Hope you find this useful,
Regards
-- Charlie



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.