Re: [XNI CHANGE PROPOSAL] XMLParseException changes and creation of XMLLocator2

On Mon, 30 Aug 2004, Andy Clark wrote:

> Michael Glavassevich wrote:
> > Here's a summary of the changes we've discussed:
> >
> > 1) Add a getCharacterOffset method to XMLLocator which returns the 
> > character offset for the current entity.
>
> What does you return if the implementation does not support
> reporting of the character offset?

It would return -1. The javadoc should state that. We should probably 
clarify that this is already the case for column and line numbers.

> > 2) Add a getVersion method to XMLLocator which returns the XML version of 
> > the current entity.
>
> Why not "getXMLVersion" to match SAX2?

Sure. That's fine.

> > 3) Add a getCharacterOffset method to XMLParseException to expose the 
> > offset from the XMLLocator.
>
> Just curious: you are exposing the XML version through the
> XMLLocator but *not* from the parse exception? I'm not in
> favor of adding it; I was just curious.

We didn't add encoding to it either back when that was added to 
XMLLocator. I don't have strong feelings either way as to whether that 
info is available on the parse exception, though both the values of 
encoding and version could be misleading, especially if the error that 
triggered the exception was related to those things.

> > If people are comfortable with these changes, I'll make the updates in CVS.
>
> Seems fine to me.
>
> --
> Andy Clark * andyc@xxxxxxxxxx
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: xerces-j-dev-unsubscribe@xxxxxxxxxxxxxx
> For additional commands, e-mail: xerces-j-dev-help@xxxxxxxxxxxxxx

---------------------------
Michael Glavassevich
XML Parser Development
IBM Toronto Lab
E-mail: mrglavas@xxxxxxxxxx
E-mail: mrglavas@xxxxxxxxxx