DO NOT REPLY [Bug 40244] New: - DSIGReferenceList::empty() not clearing references

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40244>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40244

           Summary: DSIGReferenceList::empty() not clearing references
           Product: Security
           Version: C++ 1.2.0
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: normal
          Priority: P2
         Component: C++ Signature
        AssignedTo: security-dev@xxxxxxxxxxxxxx
        ReportedBy: cantor.2@xxxxxxx


There's a mistake in the empty() method:

bool DSIGReferenceList::empty() {
        // Clear out the list - note we do NOT delete the reference elements
        return m_referenceList.empty();
}

I'm not sure why it's not deleting the reference elements. But empty() is not a
mutating method, and will not clear the vector. That's what erase() or clear()
do. empty() is just a size check.

Of course, if the references are not actually cleared, seems like you wouldn't
want to clear the vector, but if you do, this isn't the right method.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.