Re: More krysalis problems (WAS: HEAD: Krysalis-skin: some images not copied)

Nicola Ken Barozzi wrote:
> Jason End wrote:
> ...
>
> > Apart from the image problem, Krysalis isn't
> > generating the mini-toc in the left menu, and in my
> > pages main index.html, it doesn't add a pdf image/link
> > (it does add the pdf link in other files)
> > I built the site using the default forrest skin and
> > both these elements work correctly, so I don't think
> > it's due to any errors in my xmls.
>
>
> Ok, I'll check, thanks for reporting. Oh, and also thanks for the way 
> it's written, I always like reports like this that contain all the main 
> information and even a suggestion :-)

The warnings about missing directories is caused by the fact that 
forrest.build.xml was still trying to copy content and skins from the 
webapp directory during the site build. The attached patch fixes this.

Before applying the patch consider whether we still need to copy static 
content across to the build/site directory. I don't think we do as 
Cocoon will copy this stuff across when building. However, I'm not sure 
why this was introduced in the first place so I've left it in.

However, this does not fix the problem with the missing images and 
broken mini-toc. I suspect these bugs were introduced by my patch and I 
have some time today so I'm looking at it now. Nikola Ken, if you have 
made progress let me know I'm wasting my time (assuming you read this mail).

Ross
Index: forrest.build.xml
===================================================================
RCS file: /home/cvspublic/xml-forrest/src/core/forrest.build.xml,v
retrieving revision 1.11
diff -c -r1.11 forrest.build.xml
*** forrest.build.xml   26 Nov 2003 09:15:32 -0000      1.11
--- forrest.build.xml   28 Nov 2003 15:49:59 -0000
***************
*** 518,546 ****
          <property name="skindir" 
location="${project.webapp}/skins/${project.skin}"/>
          <copy toDir="${project.site-dir}" 
            overwrite="true" failonerror="false">
!           <fileset dir="${project.webapp}/content">
              <exclude name="xdocs/**"/>
            </fileset>
!           <fileset dir="${project.webapp}/resources" includes="images"/>
          </copy>
  
-         <!-- Copy skin images -->
-         <mkdir dir="${project.site-dir}/skin/images"/>
-         <copy toDir="${project.site-dir}/skin/images" overwrite="true"
-           failonerror="false">
-           <fileset dir="${skindir}/images"/>
-         </copy>
- 
-         <!-- Copy all other non-resource files -->
-         <copy toDir="${project.site-dir}/skin" 
-           overwrite="true"
-           failonerror="false">
-           <mapper type="flatten"/>
-           <fileset dir="${skindir}">
-             <exclude name="images/**"/>
-             <exclude name="xslt/**"/>
-           </fileset>
-         </copy>
          <!-- This place is our last chance to give them help messages.
               Hopefully Cocoon won't issue messages until these tasks are done.
           -->
--- 518,529 ----
          <property name="skindir" 
location="${project.webapp}/skins/${project.skin}"/>
          <copy toDir="${project.site-dir}" 
            overwrite="true" failonerror="false">
!           <fileset dir="${project.content-dir}"> <!-- fixme should this be 
raw.content-dir? -->
              <exclude name="xdocs/**"/>
            </fileset>
!           <fileset dir="${project.content-dir}/resources" includes="images"/>
          </copy>
  
          <!-- This place is our last chance to give them help messages.
               Hopefully Cocoon won't issue messages until these tasks are done.
           -->