>>>>> "HH" == Huang Haitao-G17843 <haitaohuang@xxxxxxxxxxxx> writes:
HH> I found a bug in other parts of my code. It seems working
HH> resonable now except for that there is an
HH> ArrayIndexOutOfBoundsException as follows when speciying 256
HH> colors (8bits). It seems only 254 cubes was generated but 256 was
HH> passed to the IndexColorModel constructor. When I changed
HH> IndexColorModel model=new IndexColorModel(4,n,r,g,b); to
HH> IndexColorModel model=new IndexColorModel(4,nCubes,r,g,b); The
HH> exception goes away.
Yes, this is better. Also looking at the code the '4' should in
fact be Math.ceil(Math.log2(nCubes)) (the number of bits needed to
hold nCube values). So it should have been 8 in the original code,
I suspect the JDK fixes this, but the bug should be fixed.
HH> Everthing else looks OK. After more testing, I'd like to check in
HH> the changes (both the PNGTranscoder and IndexedImage) if it's ok.
This is fine. If you send me the diffs I'll look them over and
apply them.
|
