Re: [Patch] Whitespace Handling in Batik vs ASV

Hi Tonny,

Tonny Kohar wrote:

> I would like to submit patch for the initial parsing white space
> handling. The patch is attached to this email.
    Thanks for the patch but I think there are two issues with this.
First I don't think you can do whitespace handling in the parser.
It's a little hard to know exactly where Batik fits in the XML scheme
of things (it's not 100% clear to me if it is an XML processor or an
Application) but my reading of the XML spec indicates that Batik can't
strip spaces they must be made available through the DOM.

> This patch is normalize the document on the parsing stage and it is also
> handle XML space attribute based on return value of
> XMLSupport.getXMLSpace(Element)
   I also don't think this is done quite right in some cases you
will introduce new spaces and in other cases you will remove
spaces that should be kept.

eg:
    <text>foo&amp;bar</text>
        will likely become: "foo & bar" instead of "foo&bar".
    <text>foo <baz:blah/>bar</text>
        Will become: "foo<baz:blah>bar" instead of staying the same.

> Do I need to put this into bugzilla?
   Feel free to but I think there are fundamental issues (like
violation of the XML spec) with trying to handle this in this manner.
It may be fine for your application because you know those spaces are
never important but as a general processing tool Batik can't do it.

   Finally, did the new space handling I checked in a few weeks ago
fix text for you?  Or are you worried about something else?