Re: Some patches: Bashisms, uclibc, Typo

Hi,

On Sunday 11 March 2007 18:18:55 Tobias Gruetzmacher wrote:

> I really like T2, thanks for all the hard work. I'm currently
> experimenting with the rescue system target. I once tried to work with
> LNX-BBC, but that project is mostly dead nowadays :(

You're welcome :-)

> So, here are some small patches:
> 
> my-bin-sh-is-not-bash.diff - Mostly fixes #!-lines to point to bash if
> bashism is used. /bin/sh can be dash on Debian and most certainly is
> dash in recent Ubuntu releases.
> 
> uclibc-no-locales.diff - Not sure about that one, but it seems like the
> right thing to do, otherwise I couldn't get the target to build (the
> rescue target disables locales in uclibc but tries to call a
> locale-related target of uclibc there)
> 
> package/perl/perl/strange-typo-fix.patch - New patch for Perl, fixes a
> missed quote. Maybe this wasn't noticed by anyone because that branch
> was never executed, only on my system? Oh well, that fixes it...

The patches look all good and have been committed as r22921, r22922,
and  r22923.

I only wonder why we had an explicit sh before the mkinitrd invocation, and
consider removing the explicit shell specification at this place at all, like:

Index: package/base/linux24/linux24.conf
===================================================================
--- package/base/linux24/linux24.conf   (revision 22921)
+++ package/base/linux24/linux24.conf   (working copy)
@@ -149,7 +149,7 @@
                [ -z "`type -p mkinitrd`" ] || mkinitrd ${lx_kernelrelease}
          else
                # In theory depmod here as well ...
-               [ ! -e $root/sbin/mkinitrd ] || bash $root/sbin/mkinitrd -R 
$root ${lx_kernelrelease}
+               [ ! -e $root/sbin/mkinitrd ] || $root/sbin/mkinitrd -R $root 
${lx_kernelrelease}
          fi

          echo "Fixing /lib/modules/${ver}/{build,source} symlink ..."

Yours,

-- 
  René Rebe - ExactCODE GmbH - Europe, Germany, Berlin
  http://exactcode.de | http://t2-project.org | http://rene.rebe.name
  +49 (0)30 / 255 897 45

----------------------------------------------------------- 
If you wish to unsubscribe from this mailing, send mail to
lists@xxxxxxxxxxxxxx with a subject of: unsubscribe t2