logo       

FYI: make.m4: AM_MAKE_INCLUDE will fail if doit exists: msg#00009

sysutils.automake.bugs

Subject: FYI: make.m4: AM_MAKE_INCLUDE will fail if doit exists

>>> "Philip" == Philip S Tellis <philip@xxxxxxxxxxxxx> writes:

[...]
Philip> Solution: Use the .PHONY target to tell make that doit isn't a file:
[...]

Thank you for the report. I'm installing the following patch on HEAD and
branch-1-7.

Index: ChangeLog
from Alexandre Duret-Lutz <adl@xxxxxxx>

* m4/make.m4: Rename the doit target as am__doit,
and make it phony.
Reported by Philip S Tellis.

Index: THANKS
===================================================================
RCS file: /cvs/automake/automake/THANKS,v
retrieving revision 1.186.2.27
diff -u -r1.186.2.27 THANKS
--- THANKS 20 Mar 2003 22:44:54 -0000 1.186.2.27
+++ THANKS 7 May 2003 20:46:08 -0000
@@ -174,6 +174,7 @@
Petter Reinholdtsen pere@xxxxxxxxxx
Phil Nelson phil@xxxxxxxxxx
Philip Fong pwlfong@xxxxxxxxxxxxxxxxxxxxx
+Philip S Tellis philip@xxxxxxxxxxxxx
Rainer Orth ro@xxxxxxxxxxxxxxxxxxxxxxxx
Rafael Laboissiere laboissiere@xxxxxxxxxx
Raja R Harinath harinath@xxxxxxxxxx
Index: m4/make.m4
===================================================================
RCS file: /cvs/automake/automake/m4/make.m4,v
retrieving revision 1.10
diff -u -r1.10 make.m4
--- m4/make.m4 30 May 2002 05:55:50 -0000 1.10
+++ m4/make.m4 7 May 2003 20:46:09 -0000
@@ -1,6 +1,6 @@
# Check to see how 'make' treats includes. -*- Autoconf -*-

-# Copyright (C) 2001, 2002 Free Software Foundation, Inc.
+# Copyright (C) 2001, 2002, 2003 Free Software Foundation, Inc.

# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
@@ -25,8 +25,9 @@
AC_DEFUN([AM_MAKE_INCLUDE],
[am_make=${MAKE-make}
cat > confinc << 'END'
-doit:
+am__doit:
@echo done
+.PHONY: am__doit
END
# If we don't find an include directive, just comment out the code.
AC_MSG_CHECKING([for style of include used by $am_make])
@@ -54,8 +55,8 @@
_am_result=BSD
fi
fi
-AC_SUBST(am__include)
-AC_SUBST(am__quote)
-AC_MSG_RESULT($_am_result)
+AC_SUBST([am__include])
+AC_SUBST([am__quote])
+AC_MSG_RESULT([$_am_result])
rm -f confinc confmf
])

--
Alexandre Duret-Lutz






<Prev in Thread] Current Thread [Next in Thread>
Google Custom Search

News | FAQ | advertise