[ rockbox-Patches-669440 ] Autobookmarks (multiresume) and Bookmarking, with diff

Patches item #669440, was opened at 2003-01-16 14:47
Message generated for change (Comment added) made by nobody
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=439120&aid=669440&group_id=44306

Category: None
Group: None
Status: Open
Resolution: None
Priority: 6
Submitted By: Benjamin Metzler (benjamintm)
Assigned to: Daniel Stenberg (bagder)
Summary: Autobookmarks (multiresume) and Bookmarking, with diff

Initial Comment:
This time, with the diff.

Autobookmarks (multiresume) and Bookmarking
If you have any questions/suggestions, contact me at
rockbox_dev@xxxxxxxxxxxxxxxxx The diff file was
generated off of rockbox-daily-20030116.

Autobookmarking (Multi File Resume)
-----------------------------------------------------------
This patch creates the ability to autobookmark a file
when stopping that file with the OFF button. The code
takes the existing resume information and stores that to
a file based off of the file name (foo.mp3 creates a file
called foo.mp3.resume). Each time an MP3/M3U is
played, the code will check for the the existence of the
above file and, if found, will prompt the user to load the
bookmark.

Bookmarking.
-----------------------------------------------------------
This patch has the preliminary bookmarking capability.
It can make a bookmark file with multiple bookmarks,
but will only load the first bookmark in the file. This
will
be addressed in the next release of the patch (once I
figure out how to do menus!).

Know Issues/TBDs
-----------------------------------------------------------
1. For some reason, bookmarks will occasionally fail to
load.

2. Need to create a menu when selecting a bookmark
file what will let the user choose which bookmark within
that file they want to play. Currently this loads the first
bookmark in the bmark file.

3. Manual bookmarks work, but only for MP3s. For
some reason, if attempting to bookmark a playlist, the
bookmark is created correctly, but the RockBox starts
playing at the last resume point.

4. Develop own better play capability.
FIX NOTE:
I have duplicated the code for play_resume()
without the ask_resume() calls. Again, this is not the
best way to do this, but my knowledge of how to
actually play is lacking, so I haven't developed a more
robust method

5. Need to use the language files.
FIX NOTE:
I've tried to use #define as much as possible, so it
should be trivial to use the LANG files.

6. Bookmark files are created, but they don't show up
until the next time the directory is loaded.

7. Need to come up with an icon for bookmark and
resume files

8. Need to store the autobookmark settings. They will
be restored to the defaults each time the RockBox is
turned on.

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2003-12-22 07:49

Message:
Logged In: NO 

will somebody please FINISH this???!!

----------------------------------------------------------------------

Comment By: Benjamin Metzler (benjamintm)
Date: 2003-11-05 12:35

Message:
Logged In: YES 
user_id=690256

Dynamic playlists are not supported.  They are by nature
dynamic (changable) and therefor bookmarking them would
prove futile.

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2003-11-05 00:50

Message:
Logged In: NO 

bug report :
It cannot bookmark on recursively, dynamically generated 
playlists on archos Recorder. For instance I use On+Play on a 
folder, choose insert. Then it's playing music, bookmarks 
cannot be used.

----------------------------------------------------------------------

Comment By: Lee Pilgrim (diddystar5)
Date: 2003-08-04 14:03

Message:
Logged In: YES 
user_id=618898

Could you please update this patch. It dosen't apply without 
some work now.

----------------------------------------------------------------------

Comment By: Garrett Derner (garrettderner)
Date: 2003-06-27 08:31

Message:
Logged In: YES 
user_id=770551

I did 2003-06-26 builds which include both my text viewer 
patch and Ben's bookmarking patch: 

http://www.adfreeinternet.com/~garyd/rockbox/

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2003-06-23 11:26

Message:
Logged In: NO 

Is there a new version of the compiled bookmark enabled 
firmware available? I've tried all the URLs below

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2003-03-25 07:24

Message:
Logged In: NO 

I would like to simply add a comment regarding the 
importance of Rockbox firmware and Benjamin Metzler's 
patch for bookmarks. I have many digital audiobooks, some 
of which are 18 hrs long per track. It is extremely important 
to have a resume feature to return to the last read portion as 
well as bookmarks. Bookmarks are especially important to 
get to specific sections. For example, many of the 
audiobooks have 15-20 stories spanning over 15 hrs, again, 
all on one track! With bookmarks, I can easily navigate 
through the books to get to my place in the audio file. I 
sincerely appreciate the efforts to allow these features. For 
audiobook lovers and old time radio show lovers, your 
firmware has made the archos jukebox the ultimate dream 
player. Thanks!!

----------------------------------------------------------------------

Comment By: Benjamin Metzler (benjamintm)
Date: 2003-03-16 23:05

Message:
Logged In: YES 
user_id=690256

Lot's of changes have occured in the bookmarking code.
An unpdated compiled version and a list of changes can be 
found at:
www.samuraipanda.com/bookmarks-20030316.zip

----------------------------------------------------------------------

Comment By: Daniel Stenberg (bagder)
Date: 2003-03-04 08:11

Message:
Logged In: YES 
user_id=1110

A few comments on the 0227 version:

1. don't memset() strings without reason all over
2. the comment about the bookmark format is wrong, as your
code uses "," as separator while the comment says "*". I
also think you should make the separator a proper define.

Another more minor issue is that the code rules say "less
than 80 columns" and you don't. In my editor it makes your
long lines wrap weirdly.

Also, can you elaborate on what you mean with your "TBD"
item 1 in the bookmark.c file?

Taken all into account, I think this patch is about to get
ready for inclusion.

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2003-03-03 21:00

Message:
Logged In: NO 

Thanjks so much for updating regularily! All of us using 
Rockbox apreciate you greatly!!

Thanks Again

----------------------------------------------------------------------

Comment By: Benjamin Metzler (benjamintm)
Date: 2003-02-27 21:33

Message:
Logged In: YES 
user_id=690256

An unpdated compiled version can be found at:
www.samuraipanda.com/bookmarks-20030227.zip

----------------------------------------------------------------------

Comment By: Benjamin Metzler (benjamintm)
Date: 2003-02-20 11:16

Message:
Logged In: YES 
user_id=690256

A new version has been posted.  A compiled version can be 
found at:
http://www.samuraipanda.com/bookmarks-20030220.zip
- Ben

----------------------------------------------------------------------

Comment By: Benjamin Metzler (benjamintm)
Date: 2003-02-07 14:15

Message:
Logged In: YES 
user_id=690256

A new version has been posted.  A compiled version can be 
found at:
http://www.samuraipanda.com/bookmarks-20030207.zip
- Ben

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2003-01-27 09:50

Message:
Logged In: NO 

This is absolutely a MUST HAVE feature! It's working great for 
me so far (using a AJBR15).
Who decides what features go into the next release? I want to 
cast my vote for this!
I listen to Old Time Radio shows in the car to and from work, 
and music during the day. I always had to hunt my place on 
the show when I got back in the car... not any more!
Thanks, Benjamin 

-Cameron
clidestri@xxxxxxxxx


----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2003-01-26 20:51

Message:
Logged In: NO 

Ok, thank you very much, Myself, as well as many other 
people commend your efforts, and appreciate immensely 
what you are doing.

THANK YOU!!

----------------------------------------------------------------------

Comment By: Benjamin Metzler (benjamintm)
Date: 2003-01-26 12:13

Message:
Logged In: YES 
user_id=690256

There was a bug in the first couple of releases where there 
was more access to the hard disk then necessary.  This was 
fixed in the later releases.  Download the latest version from 
http://www.samuraipanda.com/bookmarks.zip.  I've been 
updating a lot recently so there are a bunch of 
changes/additions/fixes.  Again, this is patch and may have 
bugs.  They shouldn't ruin your Recoder, but anything is 
possible.  If you are not comfortable with this, then stick with 
the 1.4 release as that is supposed to be stable.

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2003-01-26 09:58

Message:
Logged In: NO 

It may be just my imagination, but it seems that whenevre i 
use this firmware, i hear the hard drive spinning alot mor 
often, as aposed to the daily builds. It seems that every 4 or 
5 seconds, the hard drive spins up, where as in the daily 
builds, it seems like it takes 1 - 2minutes. Is this a bug, or is 
it supposed to do that? also, will it ruin my Recorder?


Thanks

----------------------------------------------------------------------

Comment By: Benjamin Metzler (benjamintm)
Date: 2003-01-21 09:43

Message:
Logged In: YES 
user_id=690256

I have posted a compiled version 
at:http://www.samuraipanda.com/bookmarks.zip.

- Ben

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2003-01-19 19:35

Message:
Logged In: NO 

Thank you very, very much!!!

----------------------------------------------------------------------

Comment By: Benjamin Metzler (benjamintm)
Date: 2003-01-19 15:51

Message:
Logged In: YES 
user_id=690256

I'll be posting a link to a compiled version next week...Ben

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2003-01-18 13:13

Message:
Logged In: NO 

WOW, seems like an awesome patch!! benjamintm, could 
you please compile it for us non-programmers, so we could 
also use this wonderful feature?

Thanks alot!!

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=439120&aid=669440&group_id=44306