logo       

libol: configure.in and make_class: msg#00054

syslog-ng

Subject: libol: configure.in and make_class


I have a couple of comments/questions about libol.

1) configure ignores the CFLAGS enviroment variable.
This affects packagers, in particular, the ones making
specfiles (%configure defines CFLAGS as "$RPM_OPT_FLAGS").

I believe the correct solution is to patch configure.in.
Something like this
----------
@@ -106,7 +106,7 @@
if test $enable_debug = "yes"; then
CFLAGS="-Wall -g"
else
- CFLAGS="-Wall -O2"
+ CFLAGS="$CFLAGS -Wall"
fi
----------
appears to work (but I'm not an autotools expert).


2) the libol makefile install the file make_class in the
directory /usr/bin. Is this file required for building
syslog-ng?

The main reason I asking this is that make_file is installed
with no interpreter. The first three lines are:

----------
#! \
-e main -s
!#
----------

The original file - make_class.in - refers to something like
"_SCSH_" but this gets replaced by an empty string.


Building system: Red Hat 9

Regards,
jpo
--
José Pedro Oliveira
* mailto: jpo@xxxxxxxxxxxx * http://gsd.di.uminho.pt/~jpo *
* gpg fingerprint = F9B6 8D87 859D 1C94 48F0 84C0 9749 9EB5 91BD 851B *
diff -ruN libol-0.3.13-orig/configure.in libol-0.3.13-modified/configure.in
--- libol-0.3.13-orig/configure.in 2004-01-19 13:20:13.000000000 +0000
+++ libol-0.3.13-modified/configure.in 2004-03-16 01:51:56.000000000 +0000
@@ -106,7 +106,7 @@
if test $enable_debug = "yes"; then
CFLAGS="-Wall -g"
else
- CFLAGS="-Wall -O2"
+ CFLAGS="$CFLAGS -Wall"
fi

MAKE_CLASS="$srcdir/utils/make_class"
<Prev in Thread] Current Thread [Next in Thread>
Google Custom Search

News | FAQ | advertise