|
[patch #5672] Yet more procedure / dictionary changes.: msg#00025statistics.pspp.devel
Follow-up Comment #1, patch #5672 (project pspp): The change to dict_delete_var worries me: now the callback will be called with the vardict indexes wrong, because variables have been moved around in the vars array but their indexes have not been updated in the vardicts. This means that some operations on variables will assert-fail (anything that asserts on dict_contains_var, for example) if called within the callback. Seems worrisome given the stated purpose of this change. Otherwise fine by me. _______________________________________________________ Reply to this item at: <http://savannah.gnu.org/patch/?5672> _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ |
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| Previous by Date: | [patch #5672] Yet more procedure / dictionary changes.: 00025, John Darrington |
|---|---|
| Next by Date: | [patch #5672] Yet more procedure / dictionary changes.: 00025, Ben Pfaff |
| Previous by Thread: | [patch #5672] Yet more procedure / dictionary changes.i: 00025, John Darrington |
| Next by Thread: | [patch #5672] Yet more procedure / dictionary changes.: 00025, Ben Pfaff |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
| News | FAQ | advertise |