On Wed, Jul 31, 2002 at 12:44:42AM -0700, Jeremy Higdon wrote:
> On Jul 31, 1:11am, Doug Ledford wrote:
> >
> > Most LLDD don't want to use too large of a number because to be truly safe
> > you must preallocate enough memory for these sg structs at init time and
> > hold it forever. You obviously can't allocate memory for a sg struct when
> > you are out of mem, it's a deadlock scenario. So, 256 elements per
> > command is 2048 bytes of permanently allocated DMAable memory per command
> > the host controller can queue (given the typical 8 byte, 32bit DMA
> > address hardware sg struct, gets worse when you support 64bit
> > addressing). Support something like 256 commands on the card total and
> > that's now 512K of memory just for sg structs and doesn't count the actual
> > scsi command blocks that the cards also need dma memory for...
>
> Why not allocate 1 (or a small number) of giant s/g lists, and N
> medium lists (where N is the max # of outstanding commands). Then,
> when you get a request that needs more s/g entries than the medium,
> you allocate a new list. If that fails, you use the preallocated
> giant list when it's available, leaving the request on the lld's
> internal queue?
For random use patterns it might be sufficient, but under lots of load
scenarios that I've seen this wouldn't work too well. It depends on
whether or not you want your driver to be able to do the full streaming
stuff that tends to blow up this type of allocation.
> I found that a good tradeoff between maximum request size and reasonable
> memory usage.
>
> Similary for the Qlogic example, you don't have to worry about throttling
> to the lld, since it can just leave commands on its internal queue if
> there isn't enough space in the request queue. You can then issue the
> queued commands when the next command completes, or you can set a timer
> to check to see if there is new space in the request queue.
This is exactly what I want to avoid. There should not be any reason that
all the low level drivers implement their own queues and timers. That
code most definitely *is* perfectly generic enough that I would like to
see the mid layer get it right and I would like to see low level drivers
yanking out queue code left and right, and instead the low level drivers
should not be required to do any more than tell the mid layer yes I can
take this or no I'm too busy right now, hold on to this until I'm ready.
--
Doug Ledford <dledford@xxxxxxxxxx> 919-754-3700 x44233
Red Hat, Inc.
1801 Varsity Dr.
Raleigh, NC 27606
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
|
