logo       

Re: warning cleanup for drivers/scsi/fdomain.c: msg#00207

Subject: Re: warning cleanup for drivers/scsi/fdomain.c
In message <E17ZOxI-0001tS-00@xxxxxxxxxxxxxxxxxxxxxx> you write:
> --- linux/drivers/scsi/fdomain.c      Mon Feb 25 13:38:04 2002
> +++ linux-fixed-warnings/drivers/scsi/fdomain.c       Sun Jul 21 21:43:37 2002
> @@ -2041,7 +2041,7 @@ int fdomain_16x0_release(struct Scsi_Hos
>               free_irq(shpnt->irq, shpnt);
>       if (shpnt->io_port && shpnt->n_io_port)
>               release_region(shpnt->io_port, shpnt->n_io_port);
> -
> +     return 0;
>  }
>  
>  MODULE_LICENSE("GPL");

[Side note to SCSI people]

This is correct, as stands, but the real fix is to declare
Scsi_Host_Template's release method to return void, since the only
caller I can find ignores the return anyway.

Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



<Prev in Thread] Current Thread [Next in Thread>