logo       

[TRIVIAL] Re: aic7xxx gcc3 warning fix: msg#00143

Subject: [TRIVIAL] Re: aic7xxx gcc3 warning fix
From:  Arnaud Launay <asl@xxxxxxxxxx>

  Le Tue, Jun 04, 2002 at 08:53:19AM +1000, Rusty Russell a écrit:
  > > Patch enclosed corrects the following warning in 2.5.20:
  > > aic7xxx_linux.c:401:27: warning: multi-line string literals are deprecated
  > Wrong fix: remove the commas at the ends of lines...
  
  Hm, found only one other driver using multilines 
(drivers/media/video/c-qcam.c),
  patch enclosed uses the same kind of params.
  
  I hope I do not bother you, else just tell me.
  
  Regards,
        Arnaud.
  -- 
  Flexion, extension !

--- trivial-2.5.28/drivers/scsi/aic7xxx/aic7xxx_linux.c.orig    Fri Jul 26 
16:36:40 2002
+++ trivial-2.5.28/drivers/scsi/aic7xxx/aic7xxx_linux.c Fri Jul 26 16:36:40 2002
@@ -398,26 +398,26 @@
 MODULE_LICENSE("Dual BSD/GPL");
 #endif
 MODULE_PARM(aic7xxx, "s");
-MODULE_PARM_DESC(aic7xxx, "period delimited, options string.
-       verbose                 Enable verbose/diagnostic logging
-       no_probe                Disable EISA/VLB controller probing
-       no_reset                Supress initial bus resets
-       extended                Enable extended geometry on all controllers
-       periodic_otag           Send an ordered tagged transaction periodically
-                               to prevent tag starvation.  This may be
-                               required by some older disk drives/RAID arrays. 
-       reverse_scan            Sort PCI devices highest Bus/Slot to lowest
-       tag_info:<tag_str>      Set per-target tag depth
-       seltime:<int>           Selection Timeout(0/256ms,1/128ms,2/64ms,3/32ms)
-
-       Sample /etc/modules.conf line:
-               Enable verbose logging
-               Disable EISA/VLB probing
-               Set tag depth on Controller 2/Target 2 to 10 tags
-               Shorten the selection timeout to 128ms from its default of 256
-
-       options aic7xxx='\"verbose.no_probe.tag_info:{{}.{}.{..10}}.seltime:1\"'
-");
+MODULE_PARM_DESC(aic7xxx, "period delimited, options string.\n\
+       verbose                 Enable verbose/diagnostic logging\n\
+       no_probe                Disable EISA/VLB controller probing\n\
+       no_reset                Supress initial bus resets\n\
+       extended                Enable extended geometry on all controllers\n\
+       periodic_otag           Send an ordered tagged transaction 
periodically\n\
+                               to prevent tag starvation.  This may be\n\
+                               required by some older disk drives/RAID arrays. 
\n\
+       reverse_scan            Sort PCI devices highest Bus/Slot to lowest\n\
+       tag_info:<tag_str>      Set per-target tag depth\n\
+       seltime:<int>           Selection 
Timeout(0/256ms,1/128ms,2/64ms,3/32ms)\n\
+\n\
+       Sample /etc/modules.conf line:\n\
+               Enable verbose logging\n\
+               Disable EISA/VLB probing\n\
+               Set tag depth on Controller 2/Target 2 to 10 tags\n\
+               Shorten the selection timeout to 128ms from its default of 
256\n\
+\n\
+       options 
aic7xxx='\"verbose.no_probe.tag_info:{{}.{}.{..10}}.seltime:1\"'\n"
+);
 #endif
 
 static void ahc_linux_handle_scsi_status(struct ahc_softc *,
-- 
  Don't blame me: the Monkey is driving
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



<Prev in Thread] Current Thread [Next in Thread>