On Fri, Jul 28, 2006 at 08:06:54AM -0400, Aron Griffis wrote:
> Hi Juan,
>
> Please don't forget to apply these spec changes once you've updated
> linux-2.6-xen.patch.
>
> - First, enable building xen on ia64.
>
> - Second, get rid of the redundant buildkdump setting for ppc64 and
> ppc64iseries, since buildkdump=1 is already the default (for that
> reason, cc'd Don Zickus who seems to have added it)
>
> diff -r bfc3d0da96c9 devel/kernel-2.6.spec
> --- a/devel/kernel-2.6.spec Fri Jul 28 07:26:52 2006 -0400
> +++ b/devel/kernel-2.6.spec Fri Jul 28 07:58:50 2006 -0400
> @@ -65,14 +65,8 @@ Summary: The Linux kernel (the core of t
> %endif
>
> # Xen only builds on i686, x86_64 and ia64 ...
> -#%ifnarch i686 x86_64 ia64
> -%ifnarch i686 x86_64
> +%ifnarch i686 x86_64 ia64
> %define buildxen 0
> -%endif
> -
> -
> -%ifarch ppc64 ppc64iseries
> -%define buildkdump 1
> %endif
>
NAK. You missed the couple of lines above the #Xen only.. where
buildkudmp is disabled. With Juan's recent change of moving the
'buildxen' definition, I can consolidate the ppc64.. stuff and the x86..
stuff together. That is the better fix. But PLEASE do not remove the
buildkdump line.
Cheers,
Don
|
