Subject: RE: Practice: Shared Code - msg#00076

Previous Message by Date: click to view message preview

RE: Practice: Shared Code

A lot, some of it not recovered till today... Mind you, as an XP project it was not run by the book... First project for client, they know better...   Accountability - the girl who was in charge of the mess was eventually let go.    Amir Kolsky XP& Software   From: Jim Shore [mailto:jshore-pIeWrqmHxcoWi8DADsUDTQ@xxxxxxxxxxxxxxxx] Sent: Thursday, April 14, 2005 1:23 AMTo: xpbookdiscussiongroup-hHKSG33TihhbjbujkaE4pw@xxxxxxxxxxxxxxxxSubject: Re: [xpe2e] Practice: Shared Code Amir Kolsky wrote:> It was a change (at least one of the cases) where the change was made in > order to implement some hardware support. That entailed chagned to parts > of the system's architecture. The code worked. The tests ran. The > changes were bad.How much effort did it take to improve the code afterwards?Jim-- James Shore - Titanium I.T. LLC - Successful SoftwareSee my new website and blog: http://www.jamesshore.comphone: 503-267-5490email: jshore-pIeWrqmHxcoWi8DADsUDTQ@xxxxxxxxxxxxxxxx Yahoo! Groups Links To visit your group on the web, go to:http://groups.yahoo.com/group/xpbookdiscussiongroup/  To unsubscribe from this group, send an email to:xpbookdiscussiongroup-unsubscribe-hHKSG33TihhbjbujkaE4pw@xxxxxxxxxxxxxxxx  Your use of Yahoo! Groups is subject to the Yahoo! Terms of Service.

Next Message by Date: click to view message preview

RE: Practice: Shared Code

It was difficult due to the amount of code entered and the fact that others built on that code.    Amir Kolsky XP& Software   From: George Dinwiddie [mailto:programminglists-HoQ9F2ghbHdg9hUCZPvPmw@xxxxxxxxxxxxxxxx] Sent: Thursday, April 14, 2005 4:39 AMTo: xpbookdiscussiongroup-hHKSG33TihhbjbujkaE4pw@xxxxxxxxxxxxxxxxSubject: Re: [xpe2e] Practice: Shared Code Amir Kolsky wrote:> I've seen cases where people undertook to change parts of the system that> they should not have touched. They tried to do their best but they ended up> botching up the job. Since we don't go about looking at every change to the> code - there are way too many of them, such changes went unnoticed until> they were, eh, noticed....While people are asking questions, what version control system were you using?  Was it difficult to identify and reverse their changes?  - George--   ----------------------------------------------------------------------   When I remember bygone days                         George Dinwiddie   I think how evening follows morn;                iDIA Computing, LLC   So many I loved were not yet dead,      gdinwiddie-HLNzD44B1AikJOqCEYON2AC/G2K4zDHf@xxxxxxxxxxxxxxxx   So many I love were not yet born.       http://www.idiacomputing.com              'The Middle' by Ogden Nash   http://www.agilemaryland.org  ---------------------------------------------------------------------- Yahoo! Groups Links To visit your group on the web, go to:http://groups.yahoo.com/group/xpbookdiscussiongroup/  To unsubscribe from this group, send an email to:xpbookdiscussiongroup-unsubscribe-hHKSG33TihhbjbujkaE4pw@xxxxxxxxxxxxxxxx  Your use of Yahoo! Groups is subject to the Yahoo! Terms of Service.

Previous Message by Thread: click to view message preview

Re: Practice: Shared Code

Ron Jeffries wrote: > So while coloring dangerous code red ... Hmmm... I wonder who's going to maintain the coloring? And how do you test that the appropriate code is colored? Even in a non-XP project, I would think that someone might notice the changes when they did an update. Unless it's a real death march, I tend to glance at changes most of the time just to keep track of what's happening in the rest of the system. - George -- ---------------------------------------------------------------------- When I remember bygone days George Dinwiddie I think how evening follows morn; iDIA Computing, LLC So many I loved were not yet dead, gdinwiddie-HLNzD44B1AikJOqCEYON2AC/G2K4zDHf@xxxxxxxxxxxxxxxx So many I love were not yet born. http://www.idiacomputing.com 'The Middle' by Ogden Nash http://www.agilemaryland.org ----------------------------------------------------------------------

Next Message by Thread: click to view message preview

Re: Practice: Shared Code

Yes, but who is going to make sure that all of the appropriate code is marked as "high difficulty"? How will you know that you've marked the code appropriately? Amir Kolsky wrote: > Incidentally, the project is not a death march. > > You don't really color... It was a metaphor.... > > Amir Kolsky > XP& Software > > > > _____ > > From: George Dinwiddie > [mailto:programminglists-HoQ9F2ghbHdg9hUCZPvPmw@xxxxxxxxxxxxxxxx] > Sent: Thursday, April 14, 2005 4:46 AM > To: xpbookdiscussiongroup-hHKSG33TihhbjbujkaE4pw@xxxxxxxxxxxxxxxx > Subject: Re: [xpe2e] Practice: Shared Code > > > Ron Jeffries wrote: > >>So while coloring dangerous code red ... > > > Hmmm... I wonder who's going to maintain the coloring? And how do you > test that the appropriate code is colored? > > Even in a non-XP project, I would think that someone might notice the > changes when they did an update. Unless it's a real death march, I tend > to glance at changes most of the time just to keep track of what's > happening in the rest of the system. > > - George > > -- ---------------------------------------------------------------------- When I remember bygone days George Dinwiddie I think how evening follows morn; iDIA Computing, LLC So many I loved were not yet dead, gdinwiddie-HLNzD44B1AikJOqCEYON2AC/G2K4zDHf@xxxxxxxxxxxxxxxx So many I love were not yet born. http://www.idiacomputing.com 'The Middle' by Ogden Nash http://www.agilemaryland.org ----------------------------------------------------------------------