Subject: Re: [HACKERS] patch for implementing
SPI_gettypemod() - msg#00243

Previous Message by Date:

Re: [HACKERS] controlling the location of server-side SSL files

On tis, 2012-01-24 at 22:05 +0200, Peter Eisentraut wrote: > > > One thing that is perhaps worth thinking about: Currently, we just > > > ignore missing root.crt and root.crl files. With this patch, we still > > > do this, even if the user has given a specific nondefault location. > > > That seems a bit odd, but I can't think of a simple way to do it better. > > > > There's a review in the CF app for this finding only minor issues, so > > I'm marking this patch therein as "Ready for Committer". > > OK, no one had any concerns about the missing file behavior I > described above? If not, then I'll commit it soon. I'm still worried about this. If we ignore a missing root.crt, then the effect is that authentication and certificate verification might fail, which would be annoying, but you'd notice it soon enough. But if we ignore a missing root.crl, we are creating a security hole. My best idea at the moment is that we should set these parameters to empty by default, and make users point them to existing files if they want to use that functionality. Comments? -- Sent via pgsql-hackers mailing list (pgsql-hackers@xxxxxxxxxxxxxx) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Next Message by Date:

Re: [HACKERS] patch for implementing SPI_gettypemod()

"Kevin Grittner" wrote: > moved this to "Replication and Recovery" Oh, that was a different patch -- I didn't see yours. (It's early, and the caffeine isn't working yet.) Anyway, you should have plenty of options now. -Kevin -- Sent via pgsql-hackers mailing list (pgsql-hackers@xxxxxxxxxxxxxx) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Previous Message by Thread:

Re: [HACKERS] patch for implementing SPI_gettypemod()

On Thu, Feb 2, 2012 at 8:11 PM, Robert Haas <robertmhaas@xxxxxxxxx> wrote: > On Wed, Feb 1, 2012 at 5:23 AM, Chetan Suttraway > <chetan.suttraway@xxxxxxxxxxxxxxxx> wrote: > > Hi All, > > > > This is regarding the TODO item : > > "Add SPI_gettypmod() to return a field's typemod from a TupleDesc" > > > > The related message is: > > http://archives.postgresql.org/pgsql-hackers/2005-11/msg00250.php > > > > This basically talks about having an SPI_gettypemod() which returns the > > typmod of a field of tupdesc > > > > Please refer the attached patch based on the suggested implementation. > > Please add this to the next CommitFest: > > https://commitfest.postgresql.org/action/commitfest_view/open > > -- > Robert Haas > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > At the given link, I am able to choose only "System administration" under commitfest topic. I think there has to be "server features" or "Miscellaneous". Regards, Chetan -- EnterpriseDB Corporation The Enterprise PostgreSQL Company Website: www.enterprisedb.com EnterpriseDB Blog : http://blogs.enterprisedb.com Follow us on Twitter : http://www.twitter.com/enterprisedb

Next Message by Thread:

Re: [HACKERS] patch for implementing SPI_gettypemod()

"Kevin Grittner" wrote: > moved this to "Replication and Recovery" Oh, that was a different patch -- I didn't see yours. (It's early, and the caffeine isn't working yet.) Anyway, you should have plenty of options now. -Kevin -- Sent via pgsql-hackers mailing list (pgsql-hackers@xxxxxxxxxxxxxx) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers