Re: [PHP-DOC] SPL Autoload Register Patch

On Mon, Jul 27, 2009 at 7:28 AM, Hannes Magnusson <hannes.magnusson@xxxxxxxxx> wrote:

Don't top-post.

On Mon, Jul 27, 2009 at 13:24, Brandon Savage<brandon@xxxxxxxxxxxxxxxxx> wrote:
>
> On Mon, Jul 27, 2009 at 7:21 AM, Hannes Magnusson
> <hannes.magnusson@xxxxxxxxx> wrote:
>>
>> Don't top-post :)
>>
>> On Mon, Jul 27, 2009 at 13:14, Brandon Savage<brandon@xxxxxxxxxxxxxxxxx>
>> wrote:
>> >
>> > On Mon, Jul 27, 2009 at 3:39 AM, Hannes Magnusson
>> > <hannes.magnusson@xxxxxxxxx> wrote:
>> >>
>> >> On Sat, Jul 25, 2009 at 18:59, Brandon
>> >> Savage<brandon@xxxxxxxxxxxxxxxxx>
>> >> wrote:
>> >> > This is my first time submitting a patch, but I was asked to add to
>> >> > the
>> >> > documentation and so here goes.
>> >> >
>> >> > Please let me know if I did anything incorrectly.
>> >>
>> >> We try to stay away from "you this" and "you that".. The
>> >> documentations should be using 3rd person :]
>> >>
>> > I fixed those issues. Let me know if there are any others.
>> >
>>
>> Function names should be wrapped in <function> elements, i.e.
>> "<function>spl_autoload_register</function> allows.."
>>
> Done.
>
> Can we make a comprehensive list of anything else that's wrong so we can
> avoid the back-and-forth?
>

() should not be used with <function>. The <function> element
automatically generates those.
<function> is also missing around __autoload.
Lines should preferably not be longer then 80chars.

Can't think of anything else.

-Hannes

Alright. Characters limited to 80, and () removed.

spl-autoload-register.diff
Description: Binary data